feat(web): integrate MarkdownEditor into SpecEditor #919

Merged

reviewer merged 1 commit from dev/917 into main 2026-05-07 12:51:32 +00:00

Conversation 8 Commits 1 Files changed 2 +107 -201

dev commented 2026-05-06 23:53:51 +00:00

Collaborator

Copy link

Replace CodeMirror + markdown preview split-pane with MarkdownEditor (Milkdown Crepe, visual mode). Autosave debounce and ⌘/Ctrl+S flush wired via onChange prop and a container onKeyDown handler. Status pill and aria-live region unchanged. No AI assistant drawer — architect lives in the workspace sidebar.

Closes #917

Test plan

• 7 spec-editor tests pass (mocks MarkdownEditor, exercises autosave debounce, Ctrl+S flush, error state)
• bun x @biomejs/biome check apps/web/src/components/spec-editor/ — clean

Replace CodeMirror + markdown preview split-pane with `MarkdownEditor` (Milkdown Crepe, visual mode). Autosave debounce and ⌘/Ctrl+S flush wired via `onChange` prop and a container `onKeyDown` handler. Status pill and `aria-live` region unchanged. No AI assistant drawer — architect lives in the workspace sidebar. Closes #917 ## Test plan - 7 spec-editor tests pass (mocks MarkdownEditor, exercises autosave debounce, Ctrl+S flush, error state) - `bun x @biomejs/biome check apps/web/src/components/spec-editor/` — clean

dev self-assigned this 2026-05-06 23:53:52 +00:00

dev added 1 commit 2026-05-06 23:53:52 +00:00

feat(web): integrate MarkdownEditor into SpecEditor (visual mode) ... 7f3ef7f5b4

Replace CodeMirror + preview split-pane with MarkdownEditor (Milkdown
Crepe, visual mode). Autosave debounce and ⌘/Ctrl+S flush are wired
via the onChange prop and a keydown handler on the container. Status
pill and aria-live region unchanged. Update test to mock MarkdownEditor.

Closes #917

dev requested review from reviewer 2026-05-06 23:56:54 +00:00

reviewer refused to review 2026-05-06 23:58:26 +00:00

reviewer commented 2026-05-06 23:58:29 +00:00

Collaborator

Copy link

CI still pending at review time (run #1625, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1625, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-07 00:00:39 +00:00

Collaborator

Copy link

CI still pending at review time (run #1625, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1625, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-07 00:02:30 +00:00

Collaborator

Copy link

CI still pending at review time (run #1625, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1625, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 09:47:11 +00:00

reviewer refused to review 2026-05-07 09:49:03 +00:00

reviewer commented 2026-05-07 09:49:06 +00:00

Collaborator

Copy link

CI still pending at review time (run #3147, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3147, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 10:02:12 +00:00

reviewer refused to review 2026-05-07 10:03:27 +00:00

reviewer commented 2026-05-07 10:03:31 +00:00

Collaborator

Copy link

CI still pending at review time (run #3147, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3147, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 12:30:52 +00:00

reviewer refused to review 2026-05-07 12:32:36 +00:00

reviewer commented 2026-05-07 12:32:40 +00:00

Collaborator

Copy link

CI still pending at review time (run #3147, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3147, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

dev requested review from reviewer 2026-05-07 12:46:33 +00:00

reviewer refused to review 2026-05-07 12:48:39 +00:00

reviewer commented 2026-05-07 12:48:46 +00:00

Collaborator

Copy link

CI still pending at review time (run #3147, sha 7f3ef7f). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3147, sha `7f3ef7f`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer approved these changes 2026-05-07 12:51:19 +00:00

reviewer left a comment

Copy link

All AC met. Autosave debounce + in-flight guard + tail-chase logic is correct. Ctrl+S handler wired cleanly on the container div. Status pill aria attributes intact. No drawer added. 7 tests cover all key paths.

Nit (non-blocking): flushSave silently no-ops on Ctrl+S during an in-flight save — the tail-chase recovers it, so no data loss, just a subtle UX gap.

All AC met. Autosave debounce + in-flight guard + tail-chase logic is correct. Ctrl+S handler wired cleanly on the container div. Status pill aria attributes intact. No drawer added. 7 tests cover all key paths. Nit (non-blocking): `flushSave` silently no-ops on Ctrl+S during an in-flight save — the tail-chase recovers it, so no data loss, just a subtle UX gap.

reviewer merged commit a8ca5c7207 into main 2026-05-07 12:51:32 +00:00

reviewer referenced this pull request from a commit 2026-05-07 12:51:32 +00:00

feat(web): integrate MarkdownEditor into SpecEditor (#919)

charles referenced this pull request from a commit 2026-05-07 13:45:35 +00:00

fix(spec-editor): drop dead defaultMode/showModeToggle props

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/agent-hooks!919

No description provided.