feat(web): MarkdownEditor — visual-only mode, drop Source tab #918

Merged

reviewer merged 1 commit from dev/915 into main 2026-05-07 09:49:16 +00:00

Conversation 5 Commits 1 Files changed 3 +26 -267

dev commented 2026-05-06 23:47:41 +00:00

Collaborator

Copy link

Drop CodeMirror source pane and mode-toggle from MarkdownEditor; render only the Milkdown Crepe visual pane. Removed props: mode, defaultMode, onModeChange, showModeToggle, sourceExtensions. Toolbar slot preserved.

Closes #915

Test plan

• bun x turbo run test — all 3243 tests pass
• bun x @biomejs/biome check . — clean
• MarkdownEditor smoke test verifies Crepe pane mounts
• Toolbar slot test confirms Assistant button renders

Drop CodeMirror source pane and mode-toggle from `MarkdownEditor`; render only the Milkdown Crepe visual pane. Removed props: `mode`, `defaultMode`, `onModeChange`, `showModeToggle`, `sourceExtensions`. Toolbar slot preserved. Closes #915 ## Test plan - `bun x turbo run test` — all 3243 tests pass - `bun x @biomejs/biome check .` — clean - `MarkdownEditor` smoke test verifies Crepe pane mounts - Toolbar slot test confirms Assistant button renders

dev self-assigned this 2026-05-06 23:47:41 +00:00

dev added 1 commit 2026-05-06 23:47:41 +00:00

feat(web): MarkdownEditor — visual-only mode, drop Source tab ... 732b55799a

Remove CodeMirror source pane, mode toggle, and mode-related props
(mode, defaultMode, onModeChange, showModeToggle, sourceExtensions).
MarkdownEditor now renders only the Milkdown Crepe visual pane.
Toolbar slot retained. Tests updated accordingly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer 2026-05-06 23:50:44 +00:00

reviewer refused to review 2026-05-06 23:52:11 +00:00

reviewer commented 2026-05-06 23:52:15 +00:00

Collaborator

Copy link

CI still pending at review time (run #3146, sha 732b557). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #3146, sha `732b557`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-06 23:53:10 +00:00

Collaborator

Copy link

CI still pending at review time (run #1624, sha 732b557). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1624, sha `732b557`). Stepping off the review request — will be re-dispatched automatically when CI completes.

reviewer commented 2026-05-06 23:55:02 +00:00

Collaborator

Copy link

CI still pending at review time (run #1624, sha 732b557). Stepping off the review request — will be re-dispatched automatically when CI completes.

CI still pending at review time (run #1624, sha `732b557`). Stepping off the review request — will be re-dispatched automatically when CI completes.

charles referenced this pull request from a commit 2026-05-07 08:50:27 +00:00

fix(post-ci): derive Forgejo aggregate state from workflow runs + janitor safety net

charles referenced this pull request from a commit 2026-05-07 09:45:59 +00:00

fix(janitor): re-wire janitor config dropped by DOB-5 service.json removal

dev requested review from reviewer 2026-05-07 09:47:11 +00:00

reviewer approved these changes 2026-05-07 09:49:07 +00:00

Dismissed

reviewer left a comment

Copy link

All AC met: mode-toggle removed, CodeMirror source path dropped, Crepe-only render, removed props cleaned up, toolbar slot preserved, SpecEditor untouched, tests updated. CI green.

All AC met: mode-toggle removed, CodeMirror source path dropped, Crepe-only render, removed props cleaned up, toolbar slot preserved, SpecEditor untouched, tests updated. CI green.

reviewer approved these changes 2026-05-07 09:49:10 +00:00

reviewer left a comment

Copy link

All AC met: mode-toggle removed, CodeMirror source path dropped, Crepe-only render, removed props cleaned up, toolbar slot preserved, SpecEditor untouched, tests updated. CI green.

All AC met: mode-toggle removed, CodeMirror source path dropped, Crepe-only render, removed props cleaned up, toolbar slot preserved, SpecEditor untouched, tests updated. CI green.

reviewer merged commit 5d91e3de05 into main 2026-05-07 09:49:16 +00:00

reviewer referenced this pull request from a commit 2026-05-07 09:49:16 +00:00

feat(web): MarkdownEditor — visual-only mode, drop Source tab (#918)

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/agent-hooks!918

No description provided.