charles/agent-hooks

Fork 0

AR-5 — Delete legacy host-mode infrastructure #1200

New issue

Closed

opened 2026-05-15 12:40:12 +00:00 by architect · 1 comment

architect commented

2026-05-15 12:40:12 +00:00

Collaborator

Why

After #1199 retires role: "host" and is_host_mode, the supporting infrastructure (HOST_MODE_TYPES allowlist, HostContainerLifecycle adapter, getArchitectWorker host filter, dockerRun host_mode branch) is unused scaffolding. Delete it; the architect agent is just another container.

Goal

Every line of code that exists because architect used to be host-mode is gone.
Mount-profile uniformity: every container gets the same bind set. Architect doesn't use the extra binds but they're harmless. Simpler code wins.

Acceptance criteria

HOST_MODE_TYPES allowlist (config loader gate) — deleted.
HostContainerLifecycle adapter — deleted.
getArchitectWorker's host_mode filter — deleted. The function just looks up the architect agent by name like any worker lookup.
dockerRun's if (host_mode) { collapse_to_credentials_bind_only } branch — deleted. Every type gets the standard bind set.
architect-dockerize.md note about "the bind-mount set collapses to the single credentials bind" is updated to reflect the uniform-mount reality, or the relevant section is dropped.
No grep hit for HOST_MODE_TYPES, HostContainerLifecycle, host_mode, getArchitectWorker.*host in the codebase.

Tests

dockerRun unit test: emitting docker run argv for architect produces the same bind set as for dev (no host_mode collapse).
reconcileOne("architect-default") test: still works exactly like every other agent; output is uniform with reconcileOne("dev-1").
No regression in the architect container's actual behaviour — the extra binds are harmless because the architect process never writes to them.

Out of scope

The dashboard UI changes (#1201 / #1202).
Reworking the per-type container config schema (a mounts: "credentials-only" | "full" knob was considered and rejected in favour of uniform mounts).

References

apps/server/src/infrastructure/container/docker-run.ts (or wherever dockerRun lives)
apps/server/src/shared/config/webhook-config.ts::HOST_MODE_TYPES
apps/server/src/infrastructure/container/host-container-lifecycle.ts
apps/server/src/domain/architect/get-architect-worker.ts
specs/architect-dockerize.md

Depends on

#1199 — this story removes the consumers; #1199 removes the producer.

Tracker

#1203

## Why After #1199 retires `role: "host"` and `is_host_mode`, the supporting infrastructure (`HOST_MODE_TYPES` allowlist, `HostContainerLifecycle` adapter, `getArchitectWorker` host filter, `dockerRun` host_mode branch) is unused scaffolding. Delete it; the architect agent is just another container. ## Goal - Every line of code that exists because architect used to be host-mode is gone. - Mount-profile uniformity: every container gets the same bind set. Architect doesn't use the extra binds but they're harmless. Simpler code wins. ## Acceptance criteria - [ ] `HOST_MODE_TYPES` allowlist (config loader gate) — deleted. - [ ] `HostContainerLifecycle` adapter — deleted. - [ ] `getArchitectWorker`'s host_mode filter — deleted. The function just looks up the architect agent by name like any worker lookup. - [ ] `dockerRun`'s `if (host_mode) { collapse_to_credentials_bind_only }` branch — deleted. Every type gets the standard bind set. - [ ] `architect-dockerize.md` note about "the bind-mount set collapses to the single credentials bind" is updated to reflect the uniform-mount reality, or the relevant section is dropped. - [ ] No grep hit for `HOST_MODE_TYPES`, `HostContainerLifecycle`, `host_mode`, `getArchitectWorker.*host` in the codebase. ## Tests - [ ] `dockerRun` unit test: emitting `docker run` argv for architect produces the same bind set as for `dev` (no host_mode collapse). - [ ] `reconcileOne("architect-default")` test: still works exactly like every other agent; output is uniform with `reconcileOne("dev-1")`. - [ ] No regression in the architect container's actual behaviour — the extra binds are harmless because the architect process never writes to them. ## Out of scope - The dashboard UI changes (#1201 / #1202). - Reworking the per-type `container` config schema (a `mounts: "credentials-only" | "full"` knob was considered and rejected in favour of uniform mounts). ## References - `apps/server/src/infrastructure/container/docker-run.ts` (or wherever `dockerRun` lives) - `apps/server/src/shared/config/webhook-config.ts::HOST_MODE_TYPES` - `apps/server/src/infrastructure/container/host-container-lifecycle.ts` - `apps/server/src/domain/architect/get-architect-worker.ts` - `specs/architect-dockerize.md` ## Depends on #1199 — this story removes the consumers; #1199 removes the producer. ## Tracker #1203

architect added the

type:user-story

area:infra

area:agents

labels

2026-05-15 12:40:26 +00:00

architect referenced this issue

2026-05-15 12:44:11 +00:00

[meta] Editable architect on the agents roster — 5-story tracker #1203

architect referenced this issue

2026-05-15 12:44:27 +00:00

AR-3 — Relay /architect/chat and /architect/spec to docker exec #1198

architect referenced this issue

2026-05-15 12:44:38 +00:00

AR-4 — Drop role: "host" and is_host_mode #1199

architect referenced this issue

2026-05-15 12:44:59 +00:00

AR-1 — Drop the architect filter from /agents/roster and drop the isHost branch #1201

code-lead referenced this issue

2026-05-15 13:08:43 +00:00

refactor(architect): make docker-exec relay mandatory in runArchitectTurn (AR-3) #1204

architect added a new dependency

2026-05-15 13:10:18 +00:00

#1199 AR-4 — Drop role: "host" and is_host_mode

architect added a new dependency

2026-05-15 13:10:18 +00:00

#1201 AR-1 — Drop the architect filter from /agents/roster and drop the isHost branch

code-lead referenced this issue from a commit

2026-05-15 14:02:02 +00:00

refactor(agents): rename role 'host' to 'planner' and retire is_host_mode (AR-4)

code-lead referenced this issue

2026-05-15 14:02:21 +00:00

refactor(agents): rename role 'host' to 'planner' and retire is_host_mode (AR-4) #1205

code-lead was assigned by architect

2026-05-15 14:23:40 +00:00

reviewer referenced this issue from a commit

2026-05-15 14:23:40 +00:00

refactor(agents): rename role 'host' to 'planner' and retire is_host_mode (AR-4)

architect commented

2026-05-15 14:23:40 +00:00

Author

Collaborator

🤖 Auto-assigned to code-lead (heuristic: area:infra + body mentions systemd/docker/reconcile — code-lead (architecture)). Reply /unassign to reroute.

🤖 Auto-assigned to **code-lead** (heuristic: area:infra + body mentions systemd/docker/reconcile — code-lead (architecture)). Reply `/unassign` to reroute.

code-lead was unassigned by architect

2026-05-15 14:38:28 +00:00

code-lead was assigned by architect

2026-05-15 14:38:28 +00:00

code-lead referenced this issue from a commit

2026-05-15 14:51:09 +00:00

refactor(architect): drop host-mode bind-mount collapse — uniform fleet mounts (AR-5)

code-lead referenced this issue from a pull request that will close it,

2026-05-15 14:51:25 +00:00

refactor(architect): drop host-mode bind-mount collapse — uniform fleet mounts (AR-5) #1206