charles/agent-hooks

Fork

You've already forked agent-hooks

Code Issues 6 Pull requests Projects Releases Packages 1 Wiki Activity Actions

AR-4 — Drop role: "host" and is_host_mode #1199

New issue

Closed

opened 2026-05-15 12:39:52 +00:00 by architect · 1 comment

architect commented

2026-05-15 12:39:52 +00:00

Collaborator

Copy link

Why

After #1198 lands the chat / spec relay, nothing live reads role === "host". The flag is dead weight: the architect agent is just another containerised type that happens to ship as a singleton with dispatchable: false. Rename + delete; no backward compat (pre-launch).

Goal

Architect's role becomes "planner" — describes the actual job (planning + spec writing + /breakdown).
is_host_mode derivation in webhook-config.mergeAgent is deleted.
Every consumer of is_host_mode / role === "host" gets its branch deleted.
Config loader rejects payloads with role: "host" — no migration shim.

Acceptance criteria

apps/server/src/shared/config/agents-default-config.ts::architect.role changes from "host" to "planner".
AGENT_ROLES_LIST (in apps/web/src/features/agents/sections/routing-section.tsx) drops "host" and adds "planner".
The zod schema in agents-config-schema.ts admits "planner", rejects "host".
webhook-config.mergeAgent no longer derives is_host_mode. The field is removed from the resolved agent shape.
apps/server/src/main.ts — every is_host_mode read deleted. Webhook dispatcher's host-mode skip / branch deleted. Code paths that fall through become uniform.
No grep hit for role === "host", host_mode, is_host_mode, isHostMode anywhere in the codebase (CI grep gate).
Config loader rejects payloads with role: "host" with a clear error message ("role 'host' is no longer supported — use 'planner'").

Tests

Schema test: { role: "planner" } validates; { role: "host" } rejects.
Webhook dispatcher unit test: routing for architect no longer goes through a host-mode skip; standard routing rules apply (and dispatchable: false keeps architect out of the worker pool naturally).
Existing dispatch tests pass without modification (the host-mode branch was no-op for architect, so deleting it shouldn't move behaviour).

Out of scope

The legacy infrastructure deletion (#1200).
The dashboard UI changes (#1201 / #1202).

References

apps/server/src/shared/config/agents-default-config.ts::architect
apps/server/src/shared/config/agents-config-schema.ts
apps/server/src/shared/config/webhook-config.ts::mergeAgent
apps/server/src/main.ts
apps/web/src/features/agents/sections/routing-section.tsx::AGENT_ROLES_LIST

Depends on

#1198 — the last role === "host" consumer must be gone before this lands.

Tracker

#1203

## Why After #1198 lands the chat / spec relay, nothing live reads `role === "host"`. The flag is dead weight: the architect agent is just another containerised type that happens to ship as a singleton with `dispatchable: false`. Rename + delete; no backward compat (pre-launch). ## Goal - Architect's role becomes `"planner"` — describes the actual job (planning + spec writing + `/breakdown`). - `is_host_mode` derivation in `webhook-config.mergeAgent` is deleted. - Every consumer of `is_host_mode` / `role === "host"` gets its branch deleted. - Config loader rejects payloads with `role: "host"` — no migration shim. ## Acceptance criteria - [ ] `apps/server/src/shared/config/agents-default-config.ts::architect.role` changes from `"host"` to `"planner"`. - [ ] `AGENT_ROLES_LIST` (in `apps/web/src/features/agents/sections/routing-section.tsx`) drops `"host"` and adds `"planner"`. - [ ] The zod schema in `agents-config-schema.ts` admits `"planner"`, rejects `"host"`. - [ ] `webhook-config.mergeAgent` no longer derives `is_host_mode`. The field is removed from the resolved agent shape. - [ ] `apps/server/src/main.ts` — every `is_host_mode` read deleted. Webhook dispatcher's host-mode skip / branch deleted. Code paths that fall through become uniform. - [ ] No grep hit for `role === "host"`, `host_mode`, `is_host_mode`, `isHostMode` anywhere in the codebase (CI grep gate). - [ ] Config loader rejects payloads with `role: "host"` with a clear error message ("role 'host' is no longer supported — use 'planner'"). ## Tests - [ ] Schema test: `{ role: "planner" }` validates; `{ role: "host" }` rejects. - [ ] Webhook dispatcher unit test: routing for architect no longer goes through a host-mode skip; standard routing rules apply (and `dispatchable: false` keeps architect out of the worker pool naturally). - [ ] Existing dispatch tests pass without modification (the host-mode branch was no-op for architect, so deleting it shouldn't move behaviour). ## Out of scope - The legacy infrastructure deletion (#1200). - The dashboard UI changes (#1201 / #1202). ## References - `apps/server/src/shared/config/agents-default-config.ts::architect` - `apps/server/src/shared/config/agents-config-schema.ts` - `apps/server/src/shared/config/webhook-config.ts::mergeAgent` - `apps/server/src/main.ts` - `apps/web/src/features/agents/sections/routing-section.tsx::AGENT_ROLES_LIST` ## Depends on #1198 — the last `role === "host"` consumer must be gone before this lands. ## Tracker #1203

architect added the

type:user-story

area:agents

labels

2026-05-15 12:40:11 +00:00

architect referenced this issue

2026-05-15 12:44:11 +00:00

[meta] Editable architect on the agents roster — 5-story tracker #1203

architect referenced this issue

2026-05-15 12:44:27 +00:00

AR-3 — Relay /architect/chat and /architect/spec to docker exec #1198

architect referenced this issue

2026-05-15 12:44:48 +00:00

AR-5 — Delete legacy host-mode infrastructure #1200

architect referenced this issue

2026-05-15 12:44:59 +00:00

AR-1 — Drop the architect filter from /agents/roster and drop the isHost branch #1201

code-lead referenced this issue

2026-05-15 13:08:43 +00:00

refactor(architect): make docker-exec relay mandatory in runArchitectTurn (AR-3) #1204

architect added a new dependency

2026-05-15 13:10:18 +00:00

#1198 AR-3 — Relay /architect/chat and /architect/spec to docker exec

architect added a new dependency

2026-05-15 13:10:18 +00:00

#1200 AR-5 — Delete legacy host-mode infrastructure

code-lead was assigned by architect

2026-05-15 13:16:23 +00:00

architect commented

2026-05-15 13:16:23 +00:00

Author

Collaborator

Copy link

🤖 Auto-assigned to code-lead (heuristic: area:agents → code-lead (architecture-touching)). Reply /unassign to reroute.

🤖 Auto-assigned to **code-lead** (heuristic: area:agents → code-lead (architecture-touching)). Reply `/unassign` to reroute.

code-lead referenced this issue from a commit

2026-05-15 14:02:02 +00:00

refactor(agents): rename role 'host' to 'planner' and retire is_host_mode (AR-4)

code-lead referenced this issue from a pull request that will close it,

2026-05-15 14:02:21 +00:00

refactor(agents): rename role 'host' to 'planner' and retire is_host_mode (AR-4) #1205

code-lead was unassigned by architect

2026-05-15 14:08:28 +00:00

code-lead was assigned by architect

2026-05-15 14:08:28 +00:00

reviewer closed this issue

2026-05-15 14:23:39 +00:00

reviewer referenced this issue from a commit

2026-05-15 14:23:40 +00:00

refactor(agents): rename role 'host' to 'planner' and retire is_host_mode (AR-4)

code-lead referenced this issue

2026-05-15 14:51:25 +00:00

refactor(architect): drop host-mode bind-mount collapse — uniform fleet mounts (AR-5) #1206

charles referenced this issue from a commit

2026-05-15 15:06:58 +00:00

refactor(architect): drop host-mode bind-mount collapse — uniform fleet mounts (AR-5) (#1206)

No Branch/Tag specified

main

dev/1213

code-lead/1210

code-lead/1202

code-lead/1201

code-lead/1199

code-lead/1198

dev/1166

dev/1168-error-banner

feat/error-banner-1168

dev/1168

dev/1165

dev/1169-board-redispatch

feat/1169-board-card-redispatch

code-lead/1164

dev/1169

dev/1170

dev/1161

code-lead/1159

code-lead/1150

code-lead/1148

dev/1149

code-lead/1151

dev/1152

code-lead/1147

code-lead/1139

code-lead/1138

code-lead/1137

code-lead/1136

code-lead/1131

code-lead/1122

code-lead/1121

code-lead/1120

code-lead/1119

code-lead/1117

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

code-lead

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#1200 AR-5 — Delete legacy host-mode infrastructure

charles/agent-hooks

Depends on

#1198 AR-3 — Relay /architect/chat and /architect/spec to docker exec

charles/agent-hooks

Reference

charles/agent-hooks#1199

Reference in a new issue

Repository

charles/agent-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns