refactor(tui): replace custom image renderer with ratatui-image #119

Merged

claude-desktop merged 1 commit from tui/ratatui-image-117 into main

2026-04-12 21:15:47 +00:00

claude-desktop commented

2026-04-12 19:08:57 +00:00

Collaborator

Summary

Replace custom ImageRenderer trait + 4 backends with ratatui-image v3.0.0
Images render as native ratatui StatefulImage widgets — no stdout race
Delete kitty.rs, sixel.rs, chafa.rs, detect.rs (-1,030 lines net)
AppCtx holds a SharedPicker instead of Arc<Mutex<Box<dyn ImageRenderer>>>
Gallery detail uses StatefulProtocol for stateful image rendering with caching
Remove flush_pending() from the render loop — no longer needed
Protocol auto-detection via Picker::from_query_stdio(), tui.toml override respected

Closes charles/loom#117

Test plan

cargo test -p loom-tui — 169 tests pass (153 unit + 16 integration)
cargo clippy -p loom-tui -- -D warnings — clean
Manual: gallery detail renders images in Kitty
Manual: gallery detail renders images in a Sixel-capable terminal
Manual: halfblock fallback works in plain terminals

🤖 Generated with Claude Code

## Summary - Replace custom `ImageRenderer` trait + 4 backends with `ratatui-image` v3.0.0 - Images render as native ratatui `StatefulImage` widgets — no stdout race - Delete `kitty.rs`, `sixel.rs`, `chafa.rs`, `detect.rs` (-1,030 lines net) - `AppCtx` holds a `SharedPicker` instead of `Arc<Mutex<Box<dyn ImageRenderer>>>` - Gallery detail uses `StatefulProtocol` for stateful image rendering with caching - Remove `flush_pending()` from the render loop — no longer needed - Protocol auto-detection via `Picker::from_query_stdio()`, `tui.toml` override respected Closes charles/loom#117 ## Test plan - [x] `cargo test -p loom-tui` — 169 tests pass (153 unit + 16 integration) - [x] `cargo clippy -p loom-tui -- -D warnings` — clean - [ ] Manual: gallery detail renders images in Kitty - [ ] Manual: gallery detail renders images in a Sixel-capable terminal - [ ] Manual: halfblock fallback works in plain terminals 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-desktop added the

area:image

type:user-story

labels

2026-04-12 19:08:57 +00:00

claude-desktop added 1 commit

2026-04-12 19:08:57 +00:00

feat(tui): replace custom image renderer with ratatui-image

QA / qa (pull_request) Failing after 8m58s

Details

c4110bb931

Replace the custom Kitty/Sixel/Chafa/Halfblock image rendering backends
with the `ratatui-image` crate (v3), which renders images as native
ratatui widgets through the normal rendering pipeline. This fixes the
stdout race condition where Kitty escape sequences collided with
ratatui's buffered output.

- Delete image/kitty.rs, sixel.rs, chafa.rs, detect.rs and the
  ImageRenderer trait
- Replace with a thin Picker wrapper in image/mod.rs
- AppCtx.renderer → AppCtx.picker (SharedPicker)
- Gallery detail view uses StatefulImage + StatefulProtocol
- Remove flush_pending() calls from the event loop
- Remove MockRenderer and old image-related integration tests
- Add gallery_selection_change_clears_image_state test

Closes charles/loom#117

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude-desktop merged commit 956a0e03f4 into main

2026-04-12 21:15:47 +00:00

claude-desktop deleted branch tui/ratatui-image-117

2026-04-12 21:15:48 +00:00

claude-desktop referenced this pull request from a commit

2026-04-12 21:15:48 +00:00

Merge pull request 'refactor(tui): replace custom image renderer with ratatui-image' (#119) from tui/ratatui-image-117 into main

claude-desktop referenced this pull request

2026-04-14 19:24:22 +00:00

tui: tracking — loom-tui v0.1.0 roadmap & implementation order #47