fix(agents): persist agent type provider chain and failover #931

Merged

charles merged 1 commit from fix/agent-type-provider-dispatch into main 2026-05-07 22:47:25 +00:00

Conversation 1 Commits 1 Files changed 10 +401 -18

claude-desktop commented 2026-05-07 21:36:06 +00:00

Collaborator

Copy link

Summary

Agent type Provider edits in the dashboard were not persisted: putAgentConfig only called identity, container, routing, and service-config endpoints, so provider chain / failover / token cap never reached SQLite.

Changes

• PUT /api/agent-types/:name/dispatch — persist provider_chain_json, failover_json, and usage_threshold_tokens on agent_type_config with validation via parseProviderChain.
• Web: extend putAgentConfig to call dispatch when dispatch fields differ; include usage_threshold_tokens in composed fetchAgentConfig snapshot.
• GET derived: merge DB dispatch over factory type config; tighten types for provider chain overlay.
• Revisions: restore path for agent_type_config revisions.
• Migration 0009: add dispatch columns via addProviderDispatchColumnsIfPresent (safe when agent_type_config is missing — legacy stub DBs).
• fix: invalidate instance skill queries with a prefix after type-level skill saves.

Testing

just qa (pre-push hook passes).

## Summary Agent type **Provider** edits in the dashboard were not persisted: `putAgentConfig` only called identity, container, routing, and service-config endpoints, so provider chain / failover / token cap never reached SQLite. ## Changes - `PUT /api/agent-types/:name/dispatch` — persist `provider_chain_json`, `failover_json`, and `usage_threshold_tokens` on `agent_type_config` with validation via `parseProviderChain`. - Web: extend `putAgentConfig` to call dispatch when dispatch fields differ; include `usage_threshold_tokens` in composed `fetchAgentConfig` snapshot. - GET `derived`: merge DB dispatch over factory type config; tighten types for provider chain overlay. - Revisions: restore path for `agent_type_config` revisions. - Migration `0009`: add dispatch columns via `addProviderDispatchColumnsIfPresent` (safe when `agent_type_config` is missing — legacy stub DBs). - **fix:** invalidate instance skill queries with a prefix after type-level skill saves. ## Testing `just qa` (pre-push hook passes).

claude-desktop added 1 commit 2026-05-07 21:36:07 +00:00

fix(agents): persist agent type provider chain and failover ... ddf660c766

- Add PUT /api/agent-types/:name/dispatch and wire putAgentConfig to save
  provider_chain, failover, and usage cap to agent_type_config.
- Extend agent_type_config schema, GET derived merge, and config revision
  restore for agent_type_config.
- Migration 0009: add dispatch columns via TS helper so legacy stub DBs
  without agent_type_config do not fail migration.
- Invalidate instance skill queries on type-level skill updates (prefix).

Co-authored-by: Cursor <cursoragent@cursor.com>

charles requested review from reviewer 2026-05-07 21:37:20 +00:00

reviewer requested changes 2026-05-07 22:23:23 +00:00

reviewer left a comment

Copy link

• ci: CI run #3190 is red (https://forge.jacquin.app/charles/claude-hooks/actions/runs/1668) — cannot approve a failing PR. Fix the failing job and push a new commit.

Code logic looks correct: schema/migration/resolver/endpoint/web client changes are consistent, addProviderDispatchColumnsIfPresent is safe for legacy stubs, revision path for agent_type_config is wired up, query prefix invalidation fix is right.

- **ci**: CI run #3190 is red (https://forge.jacquin.app/charles/claude-hooks/actions/runs/1668) — cannot approve a failing PR. Fix the failing job and push a new commit. Code logic looks correct: schema/migration/resolver/endpoint/web client changes are consistent, `addProviderDispatchColumnsIfPresent` is safe for legacy stubs, revision path for `agent_type_config` is wired up, query prefix invalidation fix is right.

charles added 1 commit 2026-05-07 22:24:49 +00:00

feat(secrets): persist operator admin PAT, hard-fail rotate-secret without it ... a00628a73c

Onboarding apply now stores the admin token under a per-forge secret name
(FORGEJO_ADMIN_TOKEN / GITLAB_ADMIN_TOKEN) after a successful mint, so
later repo-admin operations can reuse it without re-prompting. The
rotate-secret route reads that secret instead of grabbing any agent
token (which lacks admin scope on operator-owned repos and silently
502'd) and returns 412 with a clear message when the secret is absent.
The existing /secrets HTTP surface manages the value going forward.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

charles force-pushed fix/agent-type-provider-dispatch from a00628a73c to ddf660c766 2026-05-07 22:33:29 +00:00 Compare

charles merged commit 6f29699db4 into main 2026-05-07 22:47:25 +00:00

charles deleted branch fix/agent-type-provider-dispatch 2026-05-07 22:47:25 +00:00

charles referenced this pull request from a commit 2026-05-07 22:47:26 +00:00

fix(agents): persist agent type provider chain and failover (#931)

claude-desktop referenced this pull request 2026-05-07 22:54:01 +00:00

feat(secrets): persist operator admin PAT, hard-fail rotate-secret without it #933

claude-desktop referenced this pull request 2026-05-08 08:54:58 +00:00

[meta] Kill scope='builtin' at runtime — defaults live in code, not DB #934

Sign in to join this conversation.

Reviewers

No reviewers

reviewer

Labels

Clear labels   

area:agents

Agent types, pool scheduling, per-instance config

  

area:dashboard

Dashboard UI and observability surfaces

  

area:database

DB layer — schema, migrations, ORM, raw SQL

  

area:design

UI/UX mockup work — routes to designer agent

  

area:design-review

Design review dispatch — routes to design-reviewer agent

  

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

  

area:infra

Deployment, isolation, containers, systemd units

  

area:meta

Tracking, scaffolding, project setup

  

area:security

Security — routes to reviewer-security (opus)

  

area:sessions

Session-id store, Claude SDK resume logic

  

area:webhook

Forgejo webhook routing and handlers

  

area:workdir

Clone cache, worktrees, git identity

  

security

Security-sensitive issue

  

type:bug

Bug

  

type:chore

Chore

  

type:meta

Tracking or decisions, not implementation work

  

type:user-story

User story

No labels

area:agents

area:dashboard

area:database

area:design

area:design-review

area:flows

area:infra

area:meta

area:security

area:sessions

area:webhook

area:workdir

security

type:bug

type:chore

type:meta

type:user-story

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks!931

No description provided.