charles/claude-hooks
1
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

DOB-2: Migration — collapse scope='builtin' rows into scope='global', drop builtin_hash columns #794

New issue
Closed
opened 2026-05-03 18:04:38 +00:00 by claude-desktop · 3 comments
claude-desktop commented 2026-05-03 18:04:38 +00:00
Collaborator
Copy link

As a platform engineer, I want a one-shot DB migration that takes every existing scope='builtin' row in the per-kind tables, promotes it to scope='global' (when no global row already shadows it), drops it otherwise, and removes the now-vestigial builtin_hash columns — so the DB on an upgraded host carries no builtin rows or hash bookkeeping after the next restart.

DOB-1 already removes the resolver's read path for builtin, so these rows are dead data the moment that ships. This story makes the cleanup permanent and storage-clean.

Acceptance criteria

Migration

  • New file apps/server/src/infrastructure/database/migrations/010-collapse-builtin-rows.ts ships:
    • For each table with a scope column (skill, system_prompt, plugin_binding, plugin_marketplace, mcp_server, agent_type_config, agent_type_container, agent_type_routing, agent_type, service_config, label_catalog):
      • For every scope='builtin' row, if a scope='global' row with the same logical key (per-kind unique-key fields) already exists → DELETE the builtin row. Else → UPDATE its scope to 'global'.
      • Logical key per kind documented inline as a code comment, sourced from each table's existing UNIQUE INDEX.
  • After the row migration, drop the builtin_hash column from every table that carries one (agent_type, service_config, label_catalog, skill, system_prompt, plugin_binding, plugin_marketplace, mcp_server).
  • Migration is idempotent: a second run is a no-op (no builtin rows, no builtin_hash columns left).
  • Migration logs one summary line per table: [010] <table>: promoted=N, deleted=M, dropped builtin_hash.

Schema fallout

  • BuiltinHashColumns (or equivalent type) and any TS code reading .builtin_hash is removed in the same PR.
  • ConfigScope union narrows to 'global' | 'agent_type' | 'instance'. resolver.ts SCOPE_PRIORITY matches.

Tests

  • Test: seed builtin row + global row sharing same key → migration drops the builtin, keeps the global.
  • Test: seed builtin row only → migration promotes it to global with same fields.
  • Test: idempotency — second run produces zero changes, zero log lines.
  • Test: builtin_hash columns physically gone (PRAGMA table_info doesn't list them).

Out of scope

  • Removing the syncBuiltinsFromRepo function — DOB-4. It still runs at boot until DOB-4; this migration just handles the rows it's left behind.
  • Deleting config/*.json files — DOB-5.

References

  • Code: apps/server/src/infrastructure/database/migrations/ (existing migration patterns 001..009), apps/server/src/domain/agent-config/resolver.ts (SCOPE_PRIORITY).
  • Depends on: DOB-1 (#793) — resolver must already ignore builtin rows before this migration runs, otherwise the brief moment between row delete and global promote would resolve to null.
As a platform engineer, I want a one-shot DB migration that takes every existing `scope='builtin'` row in the per-kind tables, promotes it to `scope='global'` (when no `global` row already shadows it), drops it otherwise, and removes the now-vestigial `builtin_hash` columns — so the DB on an upgraded host carries no `builtin` rows or hash bookkeeping after the next restart. DOB-1 already removes the resolver's read path for `builtin`, so these rows are dead data the moment that ships. This story makes the cleanup permanent and storage-clean. ## Acceptance criteria ### Migration - [ ] New file `apps/server/src/infrastructure/database/migrations/010-collapse-builtin-rows.ts` ships: - For each table with a `scope` column (`skill`, `system_prompt`, `plugin_binding`, `plugin_marketplace`, `mcp_server`, `agent_type_config`, `agent_type_container`, `agent_type_routing`, `agent_type`, `service_config`, `label_catalog`): - For every `scope='builtin'` row, if a `scope='global'` row with the same logical key (per-kind unique-key fields) already exists → DELETE the builtin row. Else → UPDATE its scope to `'global'`. - Logical key per kind documented inline as a code comment, sourced from each table's existing UNIQUE INDEX. - [ ] After the row migration, drop the `builtin_hash` column from every table that carries one (`agent_type`, `service_config`, `label_catalog`, `skill`, `system_prompt`, `plugin_binding`, `plugin_marketplace`, `mcp_server`). - [ ] Migration is idempotent: a second run is a no-op (no `builtin` rows, no `builtin_hash` columns left). - [ ] Migration logs one summary line per table: `[010] <table>: promoted=N, deleted=M, dropped builtin_hash`. ### Schema fallout - [ ] `BuiltinHashColumns` (or equivalent type) and any TS code reading `.builtin_hash` is removed in the same PR. - [ ] `ConfigScope` union narrows to `'global' | 'agent_type' | 'instance'`. `resolver.ts` `SCOPE_PRIORITY` matches. ### Tests - [ ] Test: seed builtin row + global row sharing same key → migration drops the builtin, keeps the global. - [ ] Test: seed builtin row only → migration promotes it to global with same fields. - [ ] Test: idempotency — second run produces zero changes, zero log lines. - [ ] Test: `builtin_hash` columns physically gone (`PRAGMA table_info` doesn't list them). ## Out of scope - Removing the `syncBuiltinsFromRepo` function — DOB-4. It still runs at boot until DOB-4; this migration just handles the rows it's left behind. - Deleting `config/*.json` files — DOB-5. ## References - Code: `apps/server/src/infrastructure/database/migrations/` (existing migration patterns 001..009), `apps/server/src/domain/agent-config/resolver.ts` (`SCOPE_PRIORITY`). - Depends on: DOB-1 (#793) — resolver must already ignore `builtin` rows before this migration runs, otherwise the brief moment between row delete and `global` promote would resolve to `null`.
architect commented 2026-05-03 19:12:52 +00:00
Collaborator
Copy link

🤖 Auto-assigned to code-lead (heuristic: area:agents → code-lead (architecture-touching)). Reply /unassign to reroute.

🤖 Auto-assigned to **code-lead** (heuristic: area:agents → code-lead (architecture-touching)). Reply `/unassign` to reroute.
code-lead commented 2026-05-03 21:04:59 +00:00
Collaborator
Copy link

🦵 @charles kicked the queue — re-running address-review on @code-lead.

🦵 @charles kicked the queue — re-running address-review on @code-lead.
code-lead commented 2026-05-03 21:05:23 +00:00
Collaborator
Copy link

🦵 @charles kicked the queue — re-running address-review on @code-lead.

🦵 @charles kicked the queue — re-running address-review on @code-lead.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
chore/sync-pre-push-from-forge-base
fix/flows-yaml-dispatch-identity
feat/board-tap-to-assign
dev/1107
code-lead/1106
code-lead/1108
dev/1104
code-lead/1103
code-lead/1080
dev/1087
feat/flows-yaml-ci-events
chore/board-drop-stalled-and-density-controls
fix/flows-yaml-routes-always-register
flows-yaml/api-defaults
dev/1023
fix/event-log-history-bleed
fix/janitor-fix-ci-logs-and-cap
dev/1022
fix/board-card-provider
code-lead/1036
dev/1025
code-lead/1020
dev/1017
code-lead/1026
feat/web-shortcut-registry-1018
dev/1015
code-lead/1009
code-lead/1008
dev/975
dev/969
dev/973
dev/967
code-lead/968
code-lead/953
dev/970
dev/976
code-lead/966
code-lead/956
code-lead/951
dev/962
dev/963
dev/977
dev/955
dev/983
dev/961
dev/974
code-lead/950
code-lead/939
dev/941
dev/940
dev/937
dev/938
dev/936
dev/935
feat/web-i18n-fr-locale
feat/spec-editor-ui-polish
chore/drop-legacy-compat
fix/skills-drop-preview-pane
fix/882-skills-safety-rail
dev/911
dev/909
dev/923
dev/917
dev/915
feat/879-sr11-m2-drop-legacy-skill
code-lead/873
dev/881
code-lead/869
dev/867
code-lead/845
code-lead/843
code-lead/844
dev/837
dev/861
dev/849
code-lead/837
code-lead/842
fix/dedup-rebase-inflight
dev/838
code-lead/847
dev/833
code-lead/848
pr/838
code-lead/841
feat/settings-save-bar/836
code-lead/840
dev/846
code-lead/839
dev/832
fix/board-sse-stale-cache
dev/834
dev/835
feat/settings-breadcrumbs
feat/forge-oauth-credentials
refactor/service-config-consolidation
feat/agent-tokens-to-secrets
feat/gitlab-oauth-to-db
feat/authelia-rip-and-voice-fixes
fix/rebase-storm-and-dead-letter
code-lead/797
code-lead/796
dev/811
code-lead/798
dev/810
code-lead/795
dev/808
code-lead/794
dev/805
dev/802
dev/803
feat/avatar-menu-settings-entry
feat/per-agent-token-tracking
dev/793
dev/747
dev/752
code-lead/790
code-lead/759
dev/756
dev/760
dev/741
dev/767
dev/740
dev/709
dev/644
dev/637
boss/614
dev/600
dev/611
dev/585
fix/login-bonus-fixes
boss/544
dev/542
refactor/api-prefix-and-session-gate
dev/489
boss/531
boss/518
dev/499
boss/516
dev/530
dev/517
dev/519
dev/515
dev/522
dev/503
dev/471
boss/329
dev/417
dev/418
dev/402
boss/327
dev/334
dev/332
boss/326
boss/325
dev/331
boss/324
boss/323
boss/322
dev/294
test/s11-task-analytics
dev/262
boss/270
dev/268
foreman/ui-consolidation-spec
dev/234
boss/196
boss/176
boss/164
fix/124-session-persist-bind
boss/52
dev/87
boss/73
dev/77
dev/81
dev/82
boss/79
dev/42
dev/35
boss/7
No results found.
Labels
Clear labels   
area:agents
Agent types, pool scheduling, per-instance config

  
area:dashboard
Dashboard UI and observability surfaces

  
area:database
DB layer — schema, migrations, ORM, raw SQL

  
area:design
UI/UX mockup work — routes to designer agent

  
area:design-review
Design review dispatch — routes to design-reviewer agent

  
area:flows
Flow runner — YAML loader, executor, op registry, expression eval

  
area:infra
Deployment, isolation, containers, systemd units

  
area:meta
Tracking, scaffolding, project setup

  
area:security
Security — routes to reviewer-security (opus)

  
area:sessions
Session-id store, Claude SDK resume logic

  
area:webhook
Forgejo webhook routing and handlers

  
area:workdir
Clone cache, worktrees, git identity

  
security
Security-sensitive issue

  
type:bug
Bug

  
type:chore
Chore

  
type:meta
Tracking or decisions, not implementation work

  
type:user-story
User story

No labels
area:agents
area:dashboard
area:database
area:design
area:design-review
area:flows
area:infra
area:meta
area:security
area:sessions
area:webhook
area:workdir
security
type:bug
type:chore
type:meta
type:user-story
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
code-lead
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#796 DOB-4: Delete syncBuiltinsFromRepo + JSON-Schema validators + deprecation-warning branches
charles/claude-hooks
Depends on
#793 DOB-1: Resolver — drop scope='builtin', fall through to code-side defaults
charles/claude-hooks
Reference
charles/claude-hooks#794
No description provided.