charles/claude-hooks

Fork 0

Agents: migrate boss / dev / reviewer to container mode + give them their plugin sets #76

New issue

Closed

opened 2026-04-19 00:30:09 +00:00 by claude-desktop · 1 comment

claude-desktop commented

2026-04-19 00:30:09 +00:00

Collaborator

User story

As the operator, I want all five agents (boss, dev, reviewer,
designer, design-reviewer) to run in container mode with their own
per-agent Claude Code plugin set — so that the code-editing agents
have typescript-lsp and security-guidance in their toolkit, the
reviewer has pr-review-toolkit alongside those, and the architecture
stays uniform across the pool rather than splitting "design-side
container-mode" and "code-side host-mode".

Current state (2026-04-19)

designer + design-reviewer — container mode ✅ (PR #67),
per-agent plugin dirs ✅ (PR #75).
boss + dev + reviewer — still host mode. Their
claude-hooks-<agent> containers exist (created during #67's
sweep) but agents.json entries have no container.enabled: true,
so the service dispatches them via the host path in
agent-runner.ts. They share the single
~/.config/claude-hooks/claude-env/ isolated config dir and pick
up no plugins.

Container mode has been running for the two design agents for ~24
hours without dispatches flagging any container-specific bugs in the
paths they exercise (design-implement, design-review). What
hasn't been exercised yet is the code-agent flows —
implement / review / rebase / merge / fix-ci — under
container mode. Those are the paths this ticket validates.

Acceptance criteria

Config (`config/agents.json`)

boss, dev, reviewer each get:
- container.enabled: true
- container.credentials_host_dir: "~/.config/claude-hooks/agent-env/<agent>"
- a plugins: [...] list.
Proposed plugin sets (aligned with the analysis on
#75):
- boss: security-guidance, typescript-lsp, claude-md-management.
- dev: security-guidance, typescript-lsp.
- reviewer: security-guidance, typescript-lsp, pr-review-toolkit.

Operator setup

just agent-env-sync populates the three new per-agent dirs
(credentials + .claude.json). Idempotent.
just agent-plugins-install installs each agent's plugin list
into its own dir. Idempotent.
just containers-rebuild boss dev reviewer recreates the three
containers with the new bind sources.

Validation — one dispatch per agent

Before marking the ticket closed, exercise each code-flow path under
container mode at least once to verify no regression. Easiest
route: one trivial real dispatch per agent on a safe ticket.

dev — dispatch a trivial implement task (e.g. assign a
one-line docs-typo issue to dev) and confirm the PR opens
successfully. Checks: worktree in container, git identity /
auth via docker exec, forgejo-mcp tool calls from inside the
container, push through the shim.
reviewer — let the dev PR above trigger a review-request.
Confirms the review skill runs under container mode and the
review comment posts.
boss — approve the PR (or trigger merge.md some other way).
Confirms merge-commit creation + GPG signing under container
mode.
Smoke: scripts/smoke-creds.sh boss dev reviewer returns all
probes green including plugin presence.

Rollback plan

If any container-mode path breaks on the three code agents, revert
the agents.json entries (drop container.enabled) — they
immediately fall back to host mode. The per-agent dirs and installed
plugins remain on disk, harmless, ready for the next attempt.

Out of scope

New plugin types. The three proposed per-agent plugin lists
are the minimal defaults. Adding others (e.g. hookify,
skill-creator) is a separate decision per instance later.
Rescoping the per-type defaults into SQLite. That's #72's
remaining scope — dashboard CRUD for instance-level overrides
on top of type-level defaults. This ticket only touches the
type-level defaults in agents.json.
Dropping host mode entirely. agent-runner.ts keeps the host
code path for any agent that doesn't opt into container mode. Not
removing the branch in this PR.

References

PR #75 — per-agent plugin mechanism (landing first, designer +
design-reviewer only).
PR #67 — container mode enablement for designer + design-reviewer
(the template this ticket follows).
Issue #72 — full SQLite + dashboard per-instance customization
(longer-horizon).
Milestone: Agent pool + customization (#16).

Dependencies

Blocked by PR #75 — the agent-env-sync / agent-plugins-install
recipes land there; this ticket uses them.
Blocks: per-agent plugin benefits for the three code agents.
Nothing else depends on it.
Branch off: main after #75 merges (or fold into #75's branch
if extending that PR — see the note at the top).

Note on scope folding

This ticket exists to track the migration as a distinct piece of
work. The actual change may land inside PR #75 itself (operator
decision) — if so, this ticket closes on the same merge and the
validation dispatches above become the PR's final test-plan items.

## User story As the **operator**, I want all five agents (`boss`, `dev`, `reviewer`, `designer`, `design-reviewer`) to run in container mode with their own per-agent Claude Code plugin set — so that the code-editing agents have `typescript-lsp` and `security-guidance` in their toolkit, the reviewer has `pr-review-toolkit` alongside those, and the architecture stays uniform across the pool rather than splitting "design-side container-mode" and "code-side host-mode". ## Current state (2026-04-19) - `designer` + `design-reviewer` — container mode ✅ (PR #67), per-agent plugin dirs ✅ (PR #75). - `boss` + `dev` + `reviewer` — still **host mode**. Their `claude-hooks-<agent>` containers exist (created during #67's sweep) but `agents.json` entries have no `container.enabled: true`, so the service dispatches them via the host path in `agent-runner.ts`. They share the single `~/.config/claude-hooks/claude-env/` isolated config dir and pick up no plugins. Container mode has been running for the two design agents for ~24 hours without dispatches flagging any container-specific bugs in the paths they exercise (`design-implement`, `design-review`). What **hasn't** been exercised yet is the code-agent flows — `implement` / `review` / `rebase` / `merge` / `fix-ci` — under container mode. Those are the paths this ticket validates. ## Acceptance criteria ### Config (`config/agents.json`) - [ ] `boss`, `dev`, `reviewer` each get: - `container.enabled: true` - `container.credentials_host_dir: "~/.config/claude-hooks/agent-env/<agent>"` - a `plugins: [...]` list. - [ ] Proposed plugin sets (aligned with the analysis on [#75](https://forge.jacquin.app/charles/claude-hooks/pulls/75)): - `boss`: `security-guidance`, `typescript-lsp`, `claude-md-management`. - `dev`: `security-guidance`, `typescript-lsp`. - `reviewer`: `security-guidance`, `typescript-lsp`, `pr-review-toolkit`. ### Operator setup - [ ] `just agent-env-sync` populates the three new per-agent dirs (credentials + `.claude.json`). Idempotent. - [ ] `just agent-plugins-install` installs each agent's plugin list into its own dir. Idempotent. - [ ] `just containers-rebuild boss dev reviewer` recreates the three containers with the new bind sources. ### Validation — one dispatch per agent Before marking the ticket closed, exercise each code-flow path under container mode **at least once** to verify no regression. Easiest route: one trivial real dispatch per agent on a safe ticket. - [ ] `dev` — dispatch a trivial `implement` task (e.g. assign a one-line docs-typo issue to `dev`) and confirm the PR opens successfully. Checks: worktree in container, git identity / auth via `docker exec`, forgejo-mcp tool calls from inside the container, push through the shim. - [ ] `reviewer` — let the `dev` PR above trigger a review-request. Confirms the `review` skill runs under container mode and the review comment posts. - [ ] `boss` — approve the PR (or trigger `merge.md` some other way). Confirms merge-commit creation + GPG signing under container mode. - [ ] Smoke: `scripts/smoke-creds.sh boss dev reviewer` returns all probes green including plugin presence. ### Rollback plan If any container-mode path breaks on the three code agents, revert the `agents.json` entries (drop `container.enabled`) — they immediately fall back to host mode. The per-agent dirs and installed plugins remain on disk, harmless, ready for the next attempt. ## Out of scope - **New plugin types.** The three proposed per-agent plugin lists are the minimal defaults. Adding others (e.g. `hookify`, `skill-creator`) is a separate decision per instance later. - **Rescoping the per-type defaults into SQLite.** That's #72's remaining scope — dashboard CRUD for *instance*-level overrides on top of *type*-level defaults. This ticket only touches the type-level defaults in `agents.json`. - **Dropping host mode entirely.** `agent-runner.ts` keeps the host code path for any agent that doesn't opt into container mode. Not removing the branch in this PR. ## References - PR #75 — per-agent plugin mechanism (landing first, designer + design-reviewer only). - PR #67 — container mode enablement for designer + design-reviewer (the template this ticket follows). - Issue #72 — full SQLite + dashboard per-instance customization (longer-horizon). - Milestone: **Agent pool + customization** (#16). ## Dependencies - **Blocked by PR #75** — the `agent-env-sync` / `agent-plugins-install` recipes land there; this ticket uses them. - **Blocks:** per-agent plugin benefits for the three code agents. Nothing else depends on it. - **Branch off:** `main` after #75 merges (or fold into #75's branch if extending that PR — see the note at the top). ## Note on scope folding This ticket exists to track the migration as a distinct piece of work. The actual change may land inside PR #75 itself (operator decision) — if so, this ticket closes on the same merge and the validation dispatches above become the PR's final test-plan items.

claude-desktop added the

area:agents

type:user-story

labels

2026-04-19 00:30:14 +00:00

charles referenced this issue from a commit

2026-04-19 00:34:13 +00:00

review: migrate boss / dev / reviewer to container mode + fix marketplace

claude-desktop referenced this issue

2026-04-19 00:36:10 +00:00

Remove deprecated container.credentials_host_path backwards-compat in favor of credentials_host_dir #77

claude-desktop referenced this issue

2026-04-19 00:51:20 +00:00

refactor: remove deprecated container.credentials_host_path compat branch #78

claude-desktop referenced this issue

2026-04-19 09:38:37 +00:00

/cancel endpoint: accept an agent param instead of cancelling the first busy worker #87

charles referenced this issue from a commit

2026-04-19 16:32:35 +00:00

refactor: remove deprecated `container.credentials_host_path` compat branch (#78)

claude-desktop referenced this issue

2026-04-19 18:45:05 +00:00

fix(image+plugins): un-pin claude-code; install plugins from inside image #98

charles referenced this issue from a commit

2026-04-19 19:06:32 +00:00

fix(image+plugins): un-pin claude-code; install plugins from inside image (#98)

claude-desktop commented

2026-04-19 20:57:44 +00:00

Author

Collaborator

Validation ACs are satisfied organically — without needing dedicated smoke dispatches:

dev implement ✓ — dev shipped PR #100 (issue #95) on 2026-04-19. Trivial code change, worktree + git push + forgejo-mcp call all worked under container mode.
reviewer review ✓ — reviewer reviewed PR #98 (issue #97 review cycle) on 2026-04-19, via container mode, with plugins loaded (pr-review-toolkit + typescript-lsp + security-guidance) post-PR #98's plugin-load fix.
boss merge ✓ — boss authored PR #101 (issue #97) on 2026-04-19; the merge itself was operator-triggered but the container-mode authoring path exercised GPG signing + push.
smoke-creds.sh ✓ — all probes green after PR #98 + PR #103's hardened plugin probe, confirming all three declared plugins load (not just appear in plugin list).

Closing as met. Any future container-mode regressions surface via the smoke probe or live dispatches.

Validation ACs are satisfied organically — without needing dedicated smoke dispatches: - **dev implement** ✓ — dev shipped PR #100 (issue #95) on 2026-04-19. Trivial code change, worktree + git push + forgejo-mcp call all worked under container mode. - **reviewer review** ✓ — reviewer reviewed PR #98 (issue #97 review cycle) on 2026-04-19, via container mode, with plugins loaded (`pr-review-toolkit` + `typescript-lsp` + `security-guidance`) post-PR #98's plugin-load fix. - **boss merge** ✓ — boss authored PR #101 (issue #97) on 2026-04-19; the merge itself was operator-triggered but the container-mode authoring path exercised GPG signing + push. - **smoke-creds.sh** ✓ — all probes green after PR #98 + PR #103's hardened plugin probe, confirming all three declared plugins **load** (not just appear in `plugin list`). Closing as met. Any future container-mode regressions surface via the smoke probe or live dispatches.

claude-desktop closed this issue

2026-04-19 20:58:04 +00:00