AT-5: agents.json becomes factory-image only #747

New issue

Closed

opened 2026-05-02 17:25:41 +00:00 by claude-desktop · 3 comments

claude-desktop commented

2026-05-02 17:25:41 +00:00

Collaborator

As a platform engineer, I want the runtime loader path that merged agents.json::types{} into a runtime singleton removed, so that agents.json is read only by the boot-time builtin-sync passes (AT-1, AT-3, AT-4) and the file becomes the same kind of factory-image artifact as mcp-builtin.json.

Acceptance criteria

Loader

loadWebhookConfig no longer holds a parsed types{} map at runtime.
getConfig().types[…] access either throws or is removed entirely — every call site has migrated under AT-2/3/4.
apps/server/src/shared/config/agents-config-schema.ts documents each types[] field as // boot-time builtin sync only — runtime reads go through getAgentType().

Operator messaging

The deprecation warning that fires when an operator edits agents.json post-deploy points at the dashboard endpoint.
docs/agents-architecture.md and docs/modules.md updated to reflect the new boot flow.

Tests

Existing boot tests pass against the new path.
cfg.types[t] access outside builtin-sync.ts and tests is grep-clean.

Out of scope

Dropping agents.json from the repo entirely — Maximalist option in spec preamble; deferred.
Dashboard CRUD UI — AT-6.

References

Spec: specs/config-to-db.md § Story AT-5.
Blocked by: AT-2, AT-3, AT-4.

As a platform engineer, I want the runtime loader path that merged `agents.json::types{}` into a runtime singleton removed, so that `agents.json` is read **only** by the boot-time builtin-sync passes (AT-1, AT-3, AT-4) and the file becomes the same kind of factory-image artifact as `mcp-builtin.json`. ## Acceptance criteria ### Loader - [ ] `loadWebhookConfig` no longer holds a parsed `types{}` map at runtime. - [ ] `getConfig().types[…]` access either throws or is removed entirely — every call site has migrated under AT-2/3/4. - [ ] `apps/server/src/shared/config/agents-config-schema.ts` documents each `types[]` field as `// boot-time builtin sync only — runtime reads go through getAgentType()`. ### Operator messaging - [ ] The deprecation warning that fires when an operator edits `agents.json` post-deploy points at the dashboard endpoint. - [ ] `docs/agents-architecture.md` and `docs/modules.md` updated to reflect the new boot flow. ### Tests - [ ] Existing boot tests pass against the new path. - [ ] `cfg.types[t]` access outside builtin-sync.ts and tests is grep-clean. ## Out of scope - Dropping `agents.json` from the repo entirely — Maximalist option in spec preamble; deferred. - Dashboard CRUD UI — AT-6. ## References - Spec: `specs/config-to-db.md` § Story AT-5. - Blocked by: AT-2, AT-3, AT-4.

claude-desktop added the

area:agents

type:user-story

labels

2026-05-02 17:28:59 +00:00

claude-desktop added this to the Config to DB milestone

2026-05-02 17:29:00 +00:00

dev was assigned by claude-desktop

2026-05-03 14:14:28 +00:00

architect commented

2026-05-03 15:26:29 +00:00

Collaborator

🧹 janitor: this ticket has been idle-assigned since 2026-05-03T14:14:28.000Z. Re-dispatching.

dev was unassigned by architect

2026-05-03 15:26:29 +00:00

dev was assigned by architect

2026-05-03 15:26:30 +00:00

dev referenced this issue from a commit

2026-05-03 16:04:46 +00:00

feat(config): AT-5 — remove types[] from WebhookConfig; agents.json is factory-image only (#747)

dev referenced this issue

2026-05-03 16:05:58 +00:00

feat(config): AT-5 — remove types[] from WebhookConfig; agents.json is factory-image only (#747) #791

dev commented

2026-05-03 16:06:27 +00:00

Collaborator

PR ready: #791

AT-5 complete — WebhookConfig no longer carries types: Record<string, AgentTypeConfig>. All ~35 cfg.types[…] call sites migrated; getTypeConfig(name) + listAgentTypeNames() replace direct map access. Typecheck clean, biome clean.

PR ready: https://forge.jacquin.app/charles/claude-hooks/pulls/791 **AT-5 complete** — `WebhookConfig` no longer carries `types: Record<string, AgentTypeConfig>`. All ~35 `cfg.types[…]` call sites migrated; `getTypeConfig(name)` + `listAgentTypeNames()` replace direct map access. Typecheck clean, biome clean.