charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

AT-2: Swap cfg.types[t] consumers to getAgentType() #744

New issue

Closed

opened 2026-05-02 17:25:01 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-05-02 17:25:01 +00:00

Collaborator

Copy link

Bundle directive

This story ships in one PR with #751 (SVC-2) — both swap consumers in webhook-config.ts and would conflict heavily as separate PRs. The PR closes both (Closes #744 #751).

As a platform engineer, I want every runtime read of cfg.types[t] in apps/server/src to move to getAgentType(t), so that operator overrides on per-type fields (system prompt, model, identity, routing) take effect without a service restart and without re-reading agents.json at runtime.

Acceptance criteria

Removal

Grep across apps/server/src shows zero non-builtin-sync.ts / non-test consumers of cfg.types[…].
mergeAgent() in webhook-config.ts reads exclusively from getAgentType() — no cfg.types[t] access remains.

Hot fields covered

Identity: git_author, git_email, git_name, branch_prefix, forgejo_user, role.
Pool gating: dispatchable.
Routing: default_assignee, escalation_target, max_escalations_per_day, routes_labels, default_match_labels, reviews_authors, reviews_labels.
Architect-only: label_rules, assignee_rules, example_prompts.
MCP gating: penpot_mcp.

Container fields placeholder

Container fields (container.enabled, credentials_host_dir, image, env, lifecycle, idle_stop_seconds) are read through the joined container row exposed by getAgentType(). Behaviour swap of the actual reconcile path lives in AT-3; AT-2 only removes the cfg read.

Tests

Existing dispatch / pool / event-handler / webhook-routing tests pass unchanged.
New: a scope='global' override on dev.git_author flips the value used by the next dispatch without a restart.

Out of scope

Container reconcile path swap — covered by AT-3.
Architect routing UI affordance — covered by AT-6.

References

Spec: specs/config-to-db.md § Story AT-2.
Bundled with: #751 (SVC-2). Both swap consumers in webhook-config.ts; ship together to avoid merge conflicts on the same file.

## Bundle directive This story ships in **one PR with #751 (SVC-2)** — both swap consumers in `webhook-config.ts` and would conflict heavily as separate PRs. The PR closes both (`Closes #744 #751`). --- As a platform engineer, I want every runtime read of `cfg.types[t]` in `apps/server/src` to move to `getAgentType(t)`, so that operator overrides on per-type fields (system prompt, model, identity, routing) take effect without a service restart and without re-reading `agents.json` at runtime. ## Acceptance criteria ### Removal - [ ] Grep across `apps/server/src` shows zero non-`builtin-sync.ts` / non-test consumers of `cfg.types[…]`. - [ ] `mergeAgent()` in `webhook-config.ts` reads exclusively from `getAgentType()` — no `cfg.types[t]` access remains. ### Hot fields covered - [ ] Identity: `git_author`, `git_email`, `git_name`, `branch_prefix`, `forgejo_user`, `role`. - [ ] Pool gating: `dispatchable`. - [ ] Routing: `default_assignee`, `escalation_target`, `max_escalations_per_day`, `routes_labels`, `default_match_labels`, `reviews_authors`, `reviews_labels`. - [ ] Architect-only: `label_rules`, `assignee_rules`, `example_prompts`. - [ ] MCP gating: `penpot_mcp`. ### Container fields placeholder - [ ] Container fields (`container.enabled`, `credentials_host_dir`, `image`, `env`, `lifecycle`, `idle_stop_seconds`) are read through the joined container row exposed by `getAgentType()`. Behaviour swap of the actual reconcile path lives in AT-3; AT-2 only removes the `cfg` read. ### Tests - [ ] Existing dispatch / pool / event-handler / webhook-routing tests pass unchanged. - [ ] New: a `scope='global'` override on `dev.git_author` flips the value used by the next dispatch without a restart. ## Out of scope - Container reconcile path swap — covered by AT-3. - Architect routing UI affordance — covered by AT-6. ## References - Spec: `specs/config-to-db.md` § Story AT-2. - Bundled with: #751 (SVC-2). Both swap consumers in `webhook-config.ts`; ship together to avoid merge conflicts on the same file.

claude-desktop added the

area:agents

type:user-story

labels

2026-05-02 17:28:37 +00:00

claude-desktop added this to the Config to DB milestone

2026-05-02 17:29:00 +00:00

claude-desktop referenced this issue

2026-05-02 19:17:41 +00:00

SVC-2: Boot path swap from service.json reads to getServiceConfig() #751

dev was assigned by claude-desktop

2026-05-02 19:17:50 +00:00

dev referenced this issue from a commit

2026-05-02 19:59:36 +00:00

feat(agent-config): AT-2/SVC-2 swap cfg.types[t] to getAgentType() and getServiceConfig() (#744 #751)

dev referenced this issue from a pull request that will close it,

2026-05-02 20:00:24 +00:00

feat(agent-config): AT-2/SVC-2 swap cfg.types[t] to getAgentType() and getServiceConfig() #766

dev referenced this issue from a commit

2026-05-02 20:06:19 +00:00

feat(agent-config): AT-2/SVC-2 swap cfg.types[t] to getAgentType() and getServiceConfig() (#744 #751)

charles closed this issue

2026-05-02 20:37:03 +00:00

charles referenced this issue from a commit

2026-05-02 20:37:03 +00:00

feat(agent-config): AT-2/SVC-2 swap cfg.types[t] to getAgentType() and getServiceConfig() (#766)

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Config to DB

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#744

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns