charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

WIZ-prereq-B POST /agents/types/{old}/rename — transactional type rename #671

New issue

Closed

opened 2026-05-01 19:26:05 +00:00 by claude-desktop · 1 comment

claude-desktop commented

2026-05-01 19:26:05 +00:00

Collaborator

Copy link

User story

As a platform engineer, I want a single transactional endpoint that atomically rewrites every per-type column reference across the agent-config DB and the in-memory config cache, so renames the wizard or any future operator action triggers cannot leave the system in a half-renamed state.

Acceptance criteria

Endpoint

POST /agents/types/{old_name}/rename body { new_name }. Operator-auth-gated.
Returns 200 { ok: true, renamed: { old, new, affected_rows: { agents, agent_type_config, skill, system_prompt, plugin_binding, plugin_marketplace, mcp_server } } } on success.
Returns 400 when new_name is empty / equals old_name / clashes with an existing type / clashes with a reserved role name (host, code-lead, code, review, design, design-review).
Returns 404 when old_name does not exist.
Returns 409 when a rename is already in progress for the same source (idempotency).

Transaction

One SQLite transaction. Updates: agents.type, agent_type_config.agent_type, skill.agent_type, system_prompt.agent_type, plugin_binding.agent_type, plugin_marketplace.agent_type, mcp_server.agent_type. Returns counts per table.
After commit: updates the in-memory config cache + writes config/agents.json on disk. File-write failure logs but does not roll back the DB (DB is source of truth).
Posts a config_revision row with kind = "type_rename", name = old_name, body_snapshot = { old_name, new_name, affected_rows }.

Side effects

Triggers agent-env-sync.renderForInstance for every instance of the renamed type after commit.
Triggers an SSE agent_type_renamed event so dashboard caches invalidate.

Tests

Round-trip: create type boss, add 3 agents + 5 skill rows + 2 plugin rows. Rename to tech-lead. Every row reflects the new name; old name returns 404.
Idempotency: second rename call with same old/new returns 200 (no-op).
Reserved-name check: rename to host returns 400.
Clash check: rename boss to dev (existing) returns 400.
Atomicity: simulated DB error mid-transaction rolls back; no partial rename observable.

Out of scope

Wizard UI (WIZ-1+).
Bulk rename of multiple types.

References

specs/first-login-wizard.md §Story WIZ-prereq-B
specs/agent-config-customization.md — DB schema this rewrites.
Depends on WIZ-prereq-A.

## User story As a platform engineer, I want a single transactional endpoint that atomically rewrites every per-type column reference across the agent-config DB and the in-memory config cache, so renames the wizard or any future operator action triggers cannot leave the system in a half-renamed state. ## Acceptance criteria ### Endpoint - [ ] `POST /agents/types/{old_name}/rename` body `{ new_name }`. Operator-auth-gated. - [ ] Returns 200 `{ ok: true, renamed: { old, new, affected_rows: { agents, agent_type_config, skill, system_prompt, plugin_binding, plugin_marketplace, mcp_server } } }` on success. - [ ] Returns 400 when `new_name` is empty / equals `old_name` / clashes with an existing type / clashes with a reserved role name (`host`, `code-lead`, `code`, `review`, `design`, `design-review`). - [ ] Returns 404 when `old_name` does not exist. - [ ] Returns 409 when a rename is already in progress for the same source (idempotency). ### Transaction - [ ] One SQLite transaction. Updates: `agents.type`, `agent_type_config.agent_type`, `skill.agent_type`, `system_prompt.agent_type`, `plugin_binding.agent_type`, `plugin_marketplace.agent_type`, `mcp_server.agent_type`. Returns counts per table. - [ ] After commit: updates the in-memory config cache + writes `config/agents.json` on disk. File-write failure logs but does not roll back the DB (DB is source of truth). - [ ] Posts a `config_revision` row with `kind = "type_rename"`, `name = old_name`, `body_snapshot = { old_name, new_name, affected_rows }`. ### Side effects - [ ] Triggers `agent-env-sync.renderForInstance` for every instance of the renamed type after commit. - [ ] Triggers an SSE `agent_type_renamed` event so dashboard caches invalidate. ### Tests - [ ] Round-trip: create type `boss`, add 3 agents + 5 skill rows + 2 plugin rows. Rename to `tech-lead`. Every row reflects the new name; old name returns 404. - [ ] Idempotency: second rename call with same old/new returns 200 (no-op). - [ ] Reserved-name check: rename to `host` returns 400. - [ ] Clash check: rename `boss` to `dev` (existing) returns 400. - [ ] Atomicity: simulated DB error mid-transaction rolls back; no partial rename observable. ## Out of scope - Wizard UI (WIZ-1+). - Bulk rename of multiple types. ## References - `specs/first-login-wizard.md` §Story WIZ-prereq-B - `specs/agent-config-customization.md` — DB schema this rewrites. - Depends on **WIZ-prereq-A**.

claude-desktop added the

area:agents

type:user-story

labels

2026-05-01 19:28:10 +00:00

claude-desktop added this to the First-login wizard milestone

2026-05-01 19:28:19 +00:00

claude-desktop added a new dependency

2026-05-01 20:35:24 +00:00

#670 WIZ-prereq-A Role-keyed dispatch refactor + default type rename

claude-desktop added a new dependency

2026-05-01 20:35:34 +00:00

#672 WIZ-1 Onboarding state table + /onboarding/should-redirect trigger

claude-desktop added a new dependency

2026-05-01 20:35:34 +00:00

#675 WIZ-4 Agent types screen — rename + pool sizing + drop-design toggle

code-lead self-assigned this

2026-05-01 21:01:28 +00:00

code-lead commented

2026-05-01 21:01:28 +00:00

Collaborator

Copy link

🤖 Auto-assigned to boss (heuristic: area:agents → boss (architecture-touching)). Reply /unassign to reroute.

🤖 Auto-assigned to **boss** (heuristic: area:agents → boss (architecture-touching)). Reply `/unassign` to reroute.

code-lead referenced this issue from a commit

2026-05-01 21:14:54 +00:00

feat(agents): WIZ-prereq-B transactional agent-type rename endpoint

code-lead referenced this issue from a pull request that will close it,

2026-05-01 21:15:23 +00:00

WIZ-prereq-B transactional agent-type rename endpoint #689

code-lead closed this issue

2026-05-01 21:21:42 +00:00

code-lead referenced this issue from a commit

2026-05-01 21:21:43 +00:00

WIZ-prereq-B transactional agent-type rename endpoint (#689)

claude-desktop referenced this issue

2026-05-02 01:02:53 +00:00

BUG agent-type rename leaves worker registry stale — board column disappears #711

claude-desktop referenced this issue

2026-05-05 10:58:19 +00:00

sdk-adapter canUseTool returns no updatedInput — every tool call fires ZodError #881

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

First-login wizard

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

code-lead

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#672 WIZ-1 Onboarding state table + /onboarding/should-redirect trigger

charles/claude-hooks

#675 WIZ-4 Agent types screen — rename + pool sizing + drop-design toggle

charles/claude-hooks

Depends on

#670 WIZ-prereq-A Role-keyed dispatch refactor + default type rename

charles/claude-hooks

Reference

charles/claude-hooks#671

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns