charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

SC-7 HTTP routes for the agent-config surface #629

New issue

Closed

opened 2026-05-01 10:34:44 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-05-01 10:34:44 +00:00

Collaborator

Copy link

User story

As a frontend integrator, I want every per-kind list / read / write / fork / delete / history route exposed under a consistent /agent-config/... surface, so that the dashboard can read and mutate any artifact at any scope without bespoke endpoints per kind.

Acceptance criteria

Routes

GET /agent-config — debug endpoint: every artifact resolved for the calling agent (or a given ?agent=name query). Returns a flat list with kind + name + scope + body + provenance.
Per kind (one route block each: skills, system-prompts, plugins, marketplaces, mcp):
- GET /agent-config/{kind} — list all rows with optional ?effective_for=<agent> filter that returns the resolved layered view.
- GET /agent-config/{kind}/{name}?scope=...&agent_type=...&instance_id=...
- PUT /agent-config/{kind}/{name} body { scope, agent_type?, instance_id?, body, comment? } — upsert; writes a config_revision row before applying.
- DELETE /agent-config/{kind}/{name}?scope=...&agent_type=...&instance_id=... — drops the row, writes a "deleted" revision (snapshot is the prior body for restore).
- POST /agent-config/{kind}/{name}/fork body { from_scope, to_scope, agent_type?, instance_id? } — resolves the effective body for from_scope and writes it into the target scope.
- GET /agent-config/{kind}/{name}/revisions — paginated history.
- POST /agent-config/{kind}/{name}/revisions/{id}/restore — writes a new revision whose body is the snapshot of the targeted revision.

Transactionality + auth

Every mutation runs inside a transaction: write the config_revision row first, then apply the change. A rollback leaves no orphan revision.
All mutating routes go through the existing guardMutating rail.
Read routes (GET) are operator-auth-gated under the same SPA session pattern as /agents today.
Response envelopes match the existing apps/server/src/main.ts style ({ ok: true, data: ... } / { ok: false, error: ... }).

After-effects

Successful mutations enqueue a re-render via agent-env-sync.renderForInstance (SC-2) for every affected instance.
SSE event agent_config_changed { kind, name, scope, agent_type, instance_id } so the dashboard's TanStack Query caches can invalidate without polling.

Tests

Unit: every route's happy + 404 + 400 paths.
Unit: revision write happens before the row update — failed validation leaves no orphan revision (transaction rollback covers).
Integration: an end-to-end fork flow (operator forks a builtin skill into agent_type, edits, restores a prior revision) leaves the DB in a consistent state.

Out of scope

WebSocket push of config changes (poll-based refresh + targeted SSE event is enough for v1).
Bulk import / export.

References

specs/agent-config-customization.md §API surface and §Story SC-7
Depends on SC-1 (tables) and SC-2 (renderer) so writes propagate.

## User story As a frontend integrator, I want every per-kind list / read / write / fork / delete / history route exposed under a consistent `/agent-config/...` surface, so that the dashboard can read and mutate any artifact at any scope without bespoke endpoints per kind. ## Acceptance criteria ### Routes - [ ] `GET /agent-config` — debug endpoint: every artifact resolved for the calling agent (or a given `?agent=name` query). Returns a flat list with kind + name + scope + body + provenance. - [ ] Per kind (one route block each: skills, system-prompts, plugins, marketplaces, mcp): - [ ] `GET /agent-config/{kind}` — list all rows with optional `?effective_for=<agent>` filter that returns the resolved layered view. - [ ] `GET /agent-config/{kind}/{name}?scope=...&agent_type=...&instance_id=...` - [ ] `PUT /agent-config/{kind}/{name}` body `{ scope, agent_type?, instance_id?, body, comment? }` — upsert; writes a `config_revision` row before applying. - [ ] `DELETE /agent-config/{kind}/{name}?scope=...&agent_type=...&instance_id=...` — drops the row, writes a "deleted" revision (snapshot is the prior body for restore). - [ ] `POST /agent-config/{kind}/{name}/fork` body `{ from_scope, to_scope, agent_type?, instance_id? }` — resolves the effective body for `from_scope` and writes it into the target scope. - [ ] `GET /agent-config/{kind}/{name}/revisions` — paginated history. - [ ] `POST /agent-config/{kind}/{name}/revisions/{id}/restore` — writes a new revision whose body is the snapshot of the targeted revision. ### Transactionality + auth - [ ] Every mutation runs inside a transaction: write the `config_revision` row first, then apply the change. A rollback leaves no orphan revision. - [ ] All mutating routes go through the existing `guardMutating` rail. - [ ] Read routes (GET) are operator-auth-gated under the same SPA session pattern as `/agents` today. - [ ] Response envelopes match the existing `apps/server/src/main.ts` style (`{ ok: true, data: ... }` / `{ ok: false, error: ... }`). ### After-effects - [ ] Successful mutations enqueue a re-render via `agent-env-sync.renderForInstance` (SC-2) for every affected instance. - [ ] SSE event `agent_config_changed` `{ kind, name, scope, agent_type, instance_id }` so the dashboard's TanStack Query caches can invalidate without polling. ### Tests - [ ] Unit: every route's happy + 404 + 400 paths. - [ ] Unit: revision write happens **before** the row update — failed validation leaves no orphan revision (transaction rollback covers). - [ ] Integration: an end-to-end fork flow (operator forks a builtin skill into agent_type, edits, restores a prior revision) leaves the DB in a consistent state. ## Out of scope - WebSocket push of config changes (poll-based refresh + targeted SSE event is enough for v1). - Bulk import / export. ## References - `specs/agent-config-customization.md` §API surface and §Story SC-7 - Depends on **SC-1** (tables) and **SC-2** (renderer) so writes propagate.

claude-desktop added the

area:agents

type:user-story

labels

2026-05-01 10:36:31 +00:00

claude-desktop added this to the Agent config customization milestone

2026-05-01 10:36:40 +00:00

dev was assigned by claude-desktop

2026-05-01 12:53:02 +00:00

dev referenced this issue from a commit

2026-05-01 13:06:42 +00:00

feat(agent-config): HTTP routes for agent-config surface (SC-7, #629)

dev referenced this issue from a pull request that will close it,

2026-05-01 13:06:59 +00:00

feat(agent-config): HTTP routes for agent-config surface (SC-7) #642

code-lead closed this issue

2026-05-01 13:24:57 +00:00

code-lead referenced this issue from a commit

2026-05-01 13:24:59 +00:00

feat(agent-config): HTTP routes for agent-config surface (SC-7)

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Agent config customization

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#629

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns