#517 - feat(agents): finish ClaudeAgentPort migration — eliminate SDK leaks in agent-runner - charles/claude-hooks

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#517

claude-desktop commented

2026-04-28 09:24:41 +00:00

Collaborator

User story

As a maintainer, I want all SDK calls and types to live behind ClaudeAgentPort / SdkClaudeAgent, so that agent-runner.ts consumes only domain types and the SDK can be swapped or mocked at the boundary.

Acceptance criteria

Migration

agent-runner.ts:715–780: replace direct query({...}) call with claudeAgent.run(request) via injected ClaudeAgentPort
agent-runner.ts:24: drop SDKMessage import
agent-runner.ts:679: PR-extract regex moved into adapter (or into a domain helper if used elsewhere)
domain/foreman/foreman.ts: stop building Options directly — use ClaudeAgentPort like containerised agents
No remaining @anthropic-ai/claude-agent-sdk import outside infrastructure/agents/sdk-adapter.ts

Behavioural parity

Streaming-input path for /task/:id/steer preserved (port exposes a write-side handle)
Session-resume retry on invalid session_id (agent-runner.ts:780–814) still fires
Host-mode foreman still works (cwd workdir, no container)

Tests

Existing agent-runner tests pass with adapter swapped for an in-memory fake
New test: invalid session_id retry path covered against the fake

Out of scope

AgentDispatchPort extraction — that is the orchestrator that comes next
Container/MCP port extractions — separate issues

References

apps/server/src/domain/agent/claude-port.ts
apps/server/src/infrastructure/agents/sdk-adapter.ts
apps/server/src/infrastructure/agents/agent-runner.ts

## User story As a maintainer, I want all SDK calls and types to live behind `ClaudeAgentPort` / `SdkClaudeAgent`, so that `agent-runner.ts` consumes only domain types and the SDK can be swapped or mocked at the boundary. ## Acceptance criteria ### Migration - [ ] `agent-runner.ts:715–780`: replace direct `query({...})` call with `claudeAgent.run(request)` via injected `ClaudeAgentPort` - [ ] `agent-runner.ts:24`: drop `SDKMessage` import - [ ] `agent-runner.ts:679`: PR-extract regex moved into adapter (or into a domain helper if used elsewhere) - [ ] `domain/foreman/foreman.ts`: stop building `Options` directly — use `ClaudeAgentPort` like containerised agents - [ ] No remaining `@anthropic-ai/claude-agent-sdk` import outside `infrastructure/agents/sdk-adapter.ts` ### Behavioural parity - [ ] Streaming-input path for `/task/:id/steer` preserved (port exposes a write-side handle) - [ ] Session-resume retry on invalid session_id (`agent-runner.ts:780–814`) still fires - [ ] Host-mode foreman still works (cwd workdir, no container) ### Tests - [ ] Existing agent-runner tests pass with adapter swapped for an in-memory fake - [ ] New test: invalid session_id retry path covered against the fake ## Out of scope - AgentDispatchPort extraction — that is the orchestrator that comes next - Container/MCP port extractions — separate issues ## References - `apps/server/src/domain/agent/claude-port.ts` - `apps/server/src/infrastructure/agents/sdk-adapter.ts` - `apps/server/src/infrastructure/agents/agent-runner.ts`

claude-desktop added the

labels

2026-04-28 09:25:38 +00:00

claude-desktop referenced this issue

2026-04-28 09:26:58 +00:00

[Meta] Hexagonal: AgentDispatchPort migration #513

claude-desktop added this to the M25 — Agentic dispatch port milestone

2026-04-28 09:27:05 +00:00

code-lead was assigned by claude-desktop

2026-04-28 10:00:25 +00:00

code-lead was unassigned by claude-desktop

2026-04-28 10:01:39 +00:00