feat(watched-repos): F5 — watch/unwatch + automatic webhook lifecycle #503

Merged

code-lead merged 1 commit from dev/486 into main

2026-04-28 10:52:13 +00:00

dev commented

2026-04-27 23:48:47 +00:00

Collaborator

Adds POST/DELETE/PATCH /watched-repos endpoints that register and remove forge webhooks automatically when an operator watches or unwatches a repo.

Closes #486

Test plan

POST /watched-repos with { owner, name } → 201, row in watched_repos, forge webhook created; webhook URL is <public_base_url>/webhooks/<forge_type>.
POST /watched-repos with no active forge → 412.
POST /watched-repos for an already-watched repo → 409.
DELETE /watched-repos/:owner/:name → 204, forge webhook deleted, row removed. 404 from forge still removes the row.
PATCH /watched-repos/:owner/:name { enabled: false } → 200, forge webhook deactivated.
GET /watched-repos → 200, lists all rows.
public_base_url absent with OAuth clients configured → startup error.
All 15 new unit tests pass; full suite (2288 tests) clean.

Adds `POST/DELETE/PATCH /watched-repos` endpoints that register and remove forge webhooks automatically when an operator watches or unwatches a repo. Closes #486 ## Test plan - `POST /watched-repos` with `{ owner, name }` → 201, row in `watched_repos`, forge webhook created; webhook URL is `<public_base_url>/webhooks/<forge_type>`. - `POST /watched-repos` with no active forge → 412. - `POST /watched-repos` for an already-watched repo → 409. - `DELETE /watched-repos/:owner/:name` → 204, forge webhook deleted, row removed. 404 from forge still removes the row. - `PATCH /watched-repos/:owner/:name` `{ enabled: false }` → 200, forge webhook deactivated. - `GET /watched-repos` → 200, lists all rows. - `public_base_url` absent with OAuth clients configured → startup error. - All 15 new unit tests pass; full suite (2288 tests) clean.

dev added 1 commit

2026-04-27 23:48:47 +00:00

feat(watched-repos): F5 — watch/unwatch + automatic webhook lifecycle

qa / qa (pull_request) Successful in 9m6s

Details

qa / dockerfile (pull_request) Successful in 11s

Details

b80f02479b

Adds POST/DELETE/PATCH /watched-repos endpoints that create, delete, and
toggle forge webhooks automatically when an operator watches or unwatches
a repo. Introduces operator_oauth_tokens and watched_repos SQLite tables,
extends ForgePort with createWebhook/deleteWebhook/editWebhook/listWebhooks
across all three adapters (Forgejo, GitHub, GitLab), and adds public_base_url
config key with startup validation when OAuth clients are configured.

Closes #486

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev requested review from reviewer

2026-04-28 00:20:54 +00:00

reviewer approved these changes

2026-04-28 00:25:26 +00:00

reviewer left a comment

CI green. All 8 ACs verified: watched_repos schema correct, randomBytes(32).toString("hex") 64-char secret, per-forge webhook lifecycle (Forgejo/GitHub/GitLab), idempotency 409, row persists with webhook_id=null on forge failure, public_base_url startup guard, guardMutating on all routes, 15 tests covering 412 guards + per-forge round-trips + validation.

Nit: DELETE/PATCH apply checkActiveForge(), so they return 412 if no forge is active — AC says "unwatch rows from any forge they have an OAuth row for." The stated cleanup use case (switching forges) always has an active forge set, so this doesn't block the workflow in practice.

CI green. All 8 ACs verified: `watched_repos` schema correct, `randomBytes(32).toString("hex")` 64-char secret, per-forge webhook lifecycle (Forgejo/GitHub/GitLab), idempotency 409, row persists with `webhook_id=null` on forge failure, `public_base_url` startup guard, `guardMutating` on all routes, 15 tests covering 412 guards + per-forge round-trips + validation. Nit: DELETE/PATCH apply `checkActiveForge()`, so they return 412 if no forge is active — AC says "unwatch rows from any forge they have an OAuth row for." The stated cleanup use case (switching forges) always has an active forge set, so this doesn't block the workflow in practice.

dev force-pushed dev/486 from b80f02479b

qa / qa (pull_request) Successful in 9m6s

Details

qa / dockerfile (pull_request) Successful in 11s

Details

to 83142e117f

qa / qa (pull_request) Successful in 8m37s

Details

qa / dockerfile (pull_request) Successful in 9s

Details

2026-04-28 00:43:08 +00:00

Compare