charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

MF-2: GitLab adapter for ForgePort #293

New issue

Closed

opened 2026-04-23 23:33:11 +00:00 by code-lead · 0 comments

code-lead commented

2026-04-23 23:33:11 +00:00

Collaborator

Copy link

As a platform engineer, I want a GitLab implementation of ForgePort (REST v4, gitlab.com or self-hosted) so that GitLab-hosted repos route through the same domain pipeline as Forgejo and GitHub.

Acceptance criteria

Adapter surface

New apps/server/src/infrastructure/forge/gitlab-adapter.ts.
Auth via per-agent GitLab PAT (scope: api). Project identifier = URL-encoded owner/name.
Base URL configurable per repo (gitlab.com by default; honour self-hosted via config).

Issue / MR / note mapping

ForgeIssue ← /projects/{id}/issues/{iid}.
ForgePullRequest ← /merge_requests/{iid}:
- baseRef = target_branch
- headRef = source_branch
- headSha = sha
ForgeComment ← /notes.

Dependencies (probe + fallback)

GitLab Premium exposes issue_links with relates_to | blocks | is_blocked_by types. Free does not.
Probe once at startup (cache per session); if Premium, use native. If Free, fall back to body-parse (same parser as the GitHub adapter in MF-1).
Re-probe on error. Document behaviour in adapter header.

Reviews (approvals mapping)

GitLab uses MR approvals + discussions, not GitHub-style reviews.
Mapping:
- approval_state → approved
- emoji reaction thumbsdown on a discussion → changes_requested
- plain note → comment
listReviews returns the merged stream in that shape.
submitReview writes to the matching surface (approval for APPROVED, note + thumbsdown for REQUEST_CHANGES).

CI / pipelines

getAggregateStatus / listWorkflowRuns: /projects/{id}/pipelines/{sha}.
getJobLogs: /jobs/{jobId}/trace.

Repo scope

listAccessibleRepos: /projects?membership=true.

Tests

Cross-adapter conformance suite (MF-6) passes against the GitLab adapter using recorded fixtures.
Approvals-as-reviews mapping verified with fixtures covering approved, thumbsdown, note.
Premium-vs-Free probe has both-branch fixtures.

Out of scope

GitLab merge trains — treat as regular merge; this service uses squash.
discussions threading beyond top-level notes.
GraphQL surface — REST v4 is sufficient.
Mirroring GitLab webhooks — that is MF-3.

References

Spec: specs/multi-forge.md § MF-2.
apps/server/src/infrastructure/forge/forgejo-port.ts — port surface.
MF-1 GitHub adapter — pattern to follow.

Dependencies

Blocks on MF-4 (config schema + adapter factory).
Blocks on MF-6 (conformance harness) — GitLab is the second non-Forgejo adapter, so the harness from MF-1/MF-6 is assumed to exist and wired into just qa by the time this lands.

Depends on #295 (MF-4)
Depends on #297 (MF-6)

As a platform engineer, I want a GitLab implementation of `ForgePort` (REST v4, `gitlab.com` or self-hosted) so that GitLab-hosted repos route through the same domain pipeline as Forgejo and GitHub. ## Acceptance criteria ### Adapter surface - [ ] New `apps/server/src/infrastructure/forge/gitlab-adapter.ts`. - [ ] Auth via per-agent GitLab PAT (scope: `api`). Project identifier = URL-encoded `owner/name`. - [ ] Base URL configurable per repo (`gitlab.com` by default; honour self-hosted via config). ### Issue / MR / note mapping - [ ] `ForgeIssue` ← `/projects/{id}/issues/{iid}`. - [ ] `ForgePullRequest` ← `/merge_requests/{iid}`: - `baseRef` = `target_branch` - `headRef` = `source_branch` - `headSha` = `sha` - [ ] `ForgeComment` ← `/notes`. ### Dependencies (probe + fallback) - [ ] GitLab Premium exposes `issue_links` with `relates_to | blocks | is_blocked_by` types. Free does not. - [ ] Probe once at startup (cache per session); if Premium, use native. If Free, fall back to body-parse (same parser as the GitHub adapter in MF-1). - [ ] Re-probe on error. Document behaviour in adapter header. ### Reviews (approvals mapping) - [ ] GitLab uses MR approvals + discussions, not GitHub-style reviews. - [ ] Mapping: - `approval_state` → `approved` - emoji reaction `thumbsdown` on a discussion → `changes_requested` - plain note → `comment` - [ ] `listReviews` returns the merged stream in that shape. - [ ] `submitReview` writes to the matching surface (approval for APPROVED, note + thumbsdown for REQUEST_CHANGES). ### CI / pipelines - [ ] `getAggregateStatus` / `listWorkflowRuns`: `/projects/{id}/pipelines/{sha}`. - [ ] `getJobLogs`: `/jobs/{jobId}/trace`. ### Repo scope - [ ] `listAccessibleRepos`: `/projects?membership=true`. ### Tests - [ ] Cross-adapter conformance suite (MF-6) passes against the GitLab adapter using recorded fixtures. - [ ] Approvals-as-reviews mapping verified with fixtures covering `approved`, `thumbsdown`, `note`. - [ ] Premium-vs-Free probe has both-branch fixtures. ## Out of scope - GitLab merge trains — treat as regular merge; this service uses squash. - `discussions` threading beyond top-level notes. - GraphQL surface — REST v4 is sufficient. - Mirroring GitLab webhooks — that is MF-3. ## References - Spec: [`specs/multi-forge.md`](../src/branch/main/specs/multi-forge.md) § MF-2. - `apps/server/src/infrastructure/forge/forgejo-port.ts` — port surface. - MF-1 GitHub adapter — pattern to follow. ## Dependencies - **Blocks on MF-4** (config schema + adapter factory). - **Blocks on MF-6** (conformance harness) — GitLab is the second non-Forgejo adapter, so the harness from MF-1/MF-6 is assumed to exist and wired into `just qa` by the time this lands.  - Depends on #295 (MF-4) - Depends on #297 (MF-6)

code-lead added the

area:infra

area:security

type:user-story

labels

2026-04-23 23:33:11 +00:00

dev was assigned by code-lead

2026-04-23 23:33:11 +00:00

code-lead referenced this issue

2026-04-23 23:34:18 +00:00

MF-9: Multi-forge runbook + docs #300

code-lead referenced this issue

2026-04-23 23:34:47 +00:00

Tracking: multi-forge spec breakdown (Forgejo + GitHub + GitLab behind ForgePort) #291

dev referenced this issue from a pull request that will close it,

2026-04-23 23:42:59 +00:00

feat(forge): GitLab REST v4 adapter implementing ForgePort #304

charles referenced this issue from a commit

2026-04-24 08:13:55 +00:00

feat(forge): per-repo forge binding + adapter factory (MF-4)

claude-desktop referenced this issue

2026-04-24 08:14:26 +00:00

feat(forge): per-repo forge binding + adapter factory (MF-4) #309

code-lead closed this issue

2026-04-24 09:23:07 +00:00

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dev

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#293

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns