M19-6: Stall detection, round counter, force-merge badge polish

code-lead commented

2026-04-20 18:44:16 +00:00

Collaborator

Copy link

As an operator, I want the pipeline to surface risk at a glance — stuck stages, review-loop rounds approaching MAX_ROUNDS, force-merge triggers — so that I catch issues before the escape-hatch fires.

Acceptance criteria

Stall detection (server-side, in #M19-1 derivation)

A stage is stalled when it has been running or pending longer than its threshold without SSE activity
Per-stage thresholds, tunable via config/agents.json::pipeline:
- ci_threshold_ms (default 900_000 = 15 min)
- review_threshold_ms (default 600_000 = 10 min — PR #160 stalled at ~3 min; 10 min is the comfort margin)
- implement_threshold_ms (default 1_800_000 = 30 min)
- default_stall_ms (600_000)

UI signals

Stalled stage pills render amber ⚠. Tooltip shows stalled_since and a "Bounce" quick-action
Review stage pill shows ↺ N when round counter > 0. Pill red ↺ N ⚠ when round counter >= MAX_ROUNDS - 1 (configurable via existing max_review_rounds)
Force-merge badge (gold ★) on Merge stage card when TaskRecord.force_merge is true
Filter chip "Only stalled / at-risk" in the filter bar

Quick actions

From a stalled Review stage tooltip: "Bounce review request" → fires DELETE /requested_reviewers + POST /requested_reviewers on the PR. Auth-gated by #M18-8 (operator-only)
From a stalled CI stage: "Re-trigger workflow" deep-link to the Forgejo Actions UI (no auto-retrigger server-side — safety)

Tests

pipeline-stall.test.ts — task that hasn't emitted in >threshold marked stalled; under threshold not
pipeline-stall.test.tsx — stalled pill renders amber, tooltip surfaces Bounce action, click fires the right mutations
pipeline-round-counter.test.tsx — round counter rendering at 0, 1, N-1 (amber), N (terminator fired)

Docs

CLAUDE.md "Label routing" gains "Pipeline stall thresholds" subsection
README: "Spotting stuck PRs in the monitor" paragraph

Out of scope

Push notifications / email on stall. SSE + dashboard is enough for now
Automatic bounce — operator-pull, not auto (safety)

Dependencies

Blocks on #M19-2
Can parallel with #M19-3 + #M19-4 + #M19-5

References

Spec: specs/m19-pipeline-monitor.md §Story M19-6
Real-world stall repros this fix surfaces visually: #160 (stale REQUEST_REVIEW), #171 (CI-fallback misfire)

As an operator, I want the pipeline to surface **risk** at a glance — stuck stages, review-loop rounds approaching MAX_ROUNDS, force-merge triggers — so that I catch issues before the escape-hatch fires. ## Acceptance criteria ### Stall detection (server-side, in #M19-1 derivation) - [ ] A stage is `stalled` when it has been `running` or `pending` longer than its threshold without SSE activity - [ ] Per-stage thresholds, tunable via `config/agents.json::pipeline`: - `ci_threshold_ms` (default 900_000 = 15 min) - `review_threshold_ms` (default 600_000 = 10 min — PR #160 stalled at ~3 min; 10 min is the comfort margin) - `implement_threshold_ms` (default 1_800_000 = 30 min) - `default_stall_ms` (600_000) ### UI signals - [ ] Stalled stage pills render amber ⚠. Tooltip shows `stalled_since` and a "Bounce" quick-action - [ ] Review stage pill shows `↺ N` when round counter > 0. Pill red `↺ N ⚠` when round counter >= `MAX_ROUNDS - 1` (configurable via existing `max_review_rounds`) - [ ] Force-merge badge (gold ★) on Merge stage card when `TaskRecord.force_merge` is true - [ ] Filter chip "Only stalled / at-risk" in the filter bar ### Quick actions - [ ] From a stalled Review stage tooltip: "Bounce review request" → fires `DELETE /requested_reviewers` + `POST /requested_reviewers` on the PR. Auth-gated by #M18-8 (operator-only) - [ ] From a stalled CI stage: "Re-trigger workflow" deep-link to the Forgejo Actions UI (no auto-retrigger server-side — safety) ### Tests - [ ] `pipeline-stall.test.ts` — task that hasn't emitted in >threshold marked stalled; under threshold not - [ ] `pipeline-stall.test.tsx` — stalled pill renders amber, tooltip surfaces Bounce action, click fires the right mutations - [ ] `pipeline-round-counter.test.tsx` — round counter rendering at 0, 1, N-1 (amber), N (terminator fired) ### Docs - [ ] CLAUDE.md "Label routing" gains "Pipeline stall thresholds" subsection - [ ] README: "Spotting stuck PRs in the monitor" paragraph ## Out of scope - Push notifications / email on stall. SSE + dashboard is enough for now - Automatic bounce — operator-pull, not auto (safety) ## Dependencies - **Blocks on #M19-2** - **Can parallel with #M19-3 + #M19-4 + #M19-5** ## References - Spec: `specs/m19-pipeline-monitor.md` §Story M19-6 - Real-world stall repros this fix surfaces visually: #160 (stale REQUEST_REVIEW), #171 (CI-fallback misfire)

code-lead added this to the Pipeline monitor milestone

2026-04-20 18:44:16 +00:00

code-lead added the

area:dashboard

type:user-story

labels

2026-04-20 18:44:16 +00:00

claude-desktop commented

2026-04-20 19:00:13 +00:00

Collaborator

Copy link

Mockup reference: this story blocks on the Penpot frames produced by #181 (M19-0) — specifically the Stall tooltip and Filter bar frames (round counter, force-merge badge, "Only stalled / at-risk" toggle). Do not start CSS/layout work until the designer hands off and the design-reviewer verdict is APPROVED.

**Mockup reference**: this story blocks on the Penpot frames produced by **#181 (M19-0)** — specifically the **Stall tooltip** and **Filter bar** frames (round counter, force-merge badge, "Only stalled / at-risk" toggle). Do not start CSS/layout work until the designer hands off and the `design-reviewer` verdict is APPROVED.

code-lead was assigned by claude-desktop

2026-04-20 21:53:34 +00:00

code-lead referenced this issue from a commit

2026-04-20 22:18:01 +00:00

feat(pipeline): stall detection, round counter, force-merge polish (M19-6)

code-lead referenced this issue from a pull request that will close it,

2026-04-20 22:18:28 +00:00

feat(pipeline): M19-6 stall detection, round counter, force-merge polish #195

code-lead referenced this issue from a commit

2026-04-20 22:25:14 +00:00

feat(pipeline): stall detection, round counter, force-merge polish (M19-6)

code-lead referenced this issue from a commit

2026-04-20 23:07:56 +00:00

feat(pipeline): stall detection, round counter, force-merge polish (M19-6)

code-lead closed this issue

2026-04-20 23:13:47 +00:00

code-lead referenced this issue from a commit

2026-04-20 23:13:49 +00:00

feat(pipeline): M19-6 stall detection, round counter, force-merge polish

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Pipeline monitor

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

code-lead

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#179

Rows
Columns

M19-6: Stall detection, round counter, force-merge badge polish #179

Acceptance criteria

Stall detection (server-side, in #M19-1 derivation)

UI signals

Quick actions

Tests

Docs

Out of scope

Dependencies

References