charles/claude-hooks

Fork

You've already forked claude-hooks

Code Issues 10 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Port slash commands (/hold, /ready, /no-ready, /unassign, /ready-stack) to YAML flows #1094

New issue

Closed

opened 2026-05-10 23:30:56 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-05-10 23:30:56 +00:00

Collaborator

Copy link

As an operator, I want issue-comment slash commands to be driven by YAML flows, so that the orphaned handleSlashCommandOther handler can be deleted and operators can audit command behaviour from flows/defaults/.

Context

apps/server/src/domain/workflow/event-handlers.ts:773 handleSlashCommandOther is orphaned — no production caller. Slash commands (/hold, /ready, /no-ready, /unassign, /ready-stack) are silently broken unless invoked via a legacy code path I haven't identified. /breakdown is already ported via flows/defaults/breakdown-comment.yml.

Acceptance criteria

Expression-eval helper

Add comment_matches(regex) predicate to the YAML expression-eval surface (matches against event.comment.body)
OR expose event.comment.body with a startsWith helper — pick whichever is cheaper to add to the parser

Ops

is_trusted_user op — wraps isTrustedUser; inputs login, repo; outputs {trusted: bool}
apply_hold_command op — wraps applyHoldCommand(set: true); inputs repo, issue_number, author
clear_hold_command op — wraps applyHoldCommand(set: false); inputs repo, issue_number
apply_unassign_command op — wraps applyUnassignCommand; inputs repo, issue_number, author
apply_ready_stack_command op — wraps applyReadyStackCommand; inputs repo, issue_number, author

Flows

flows/defaults/slash-hold.yml — matches ^/hold or ^/no-ready → is_trusted_user gate → apply_hold_command
flows/defaults/slash-ready.yml — matches ^/ready\b (not /ready-stack) → trust gate → clear_hold_command
flows/defaults/slash-unassign.yml — matches ^/unassign → trust gate → apply_unassign_command
flows/defaults/slash-ready-stack.yml — matches ^/ready-stack → trust gate → apply_ready_stack_command

Tests

Unit tests for each op + is_trusted_user predicate
Expression-eval tests for comment_matches
Flow integration tests for each slash flow (trusted user accepted; untrusted user rejected)
Verify /breakdown flow still works (no regression on the one already-ported command)

Cleanup

Delete handleSlashCommandOther and applyReadyStackCommand handler exports from event-handlers.ts (keep applyHoldCommand / applyUnassignCommand / applyReadyStackCommand as op implementations)
Delete their tests

Out of scope

CI events — separate ticket (#1092)
PR-closed cleanup — separate ticket (#1093)
legacy* executor hooks — separate ticket

References

apps/server/src/domain/workflow/event-handlers.ts:754-820 (handler impl + command regexes)
apps/server/src/domain/workflow/deps.ts (applyHoldCommand, applyUnassignCommand)
flows/defaults/breakdown-comment.yml (template for issue_comment trigger usage)

As an operator, I want issue-comment slash commands to be driven by YAML flows, so that the orphaned `handleSlashCommandOther` handler can be deleted and operators can audit command behaviour from `flows/defaults/`. ## Context `apps/server/src/domain/workflow/event-handlers.ts:773 handleSlashCommandOther` is orphaned — no production caller. Slash commands (`/hold`, `/ready`, `/no-ready`, `/unassign`, `/ready-stack`) are silently broken unless invoked via a legacy code path I haven't identified. `/breakdown` is already ported via `flows/defaults/breakdown-comment.yml`. ## Acceptance criteria ### Expression-eval helper - [ ] Add `comment_matches(regex)` predicate to the YAML expression-eval surface (matches against `event.comment.body`) - [ ] OR expose `event.comment.body` with a `startsWith` helper — pick whichever is cheaper to add to the parser ### Ops - [ ] `is_trusted_user` op — wraps `isTrustedUser`; inputs `login, repo`; outputs `{trusted: bool}` - [ ] `apply_hold_command` op — wraps `applyHoldCommand(set: true)`; inputs `repo, issue_number, author` - [ ] `clear_hold_command` op — wraps `applyHoldCommand(set: false)`; inputs `repo, issue_number` - [ ] `apply_unassign_command` op — wraps `applyUnassignCommand`; inputs `repo, issue_number, author` - [ ] `apply_ready_stack_command` op — wraps `applyReadyStackCommand`; inputs `repo, issue_number, author` ### Flows - [ ] `flows/defaults/slash-hold.yml` — matches `^/hold` or `^/no-ready` → `is_trusted_user` gate → `apply_hold_command` - [ ] `flows/defaults/slash-ready.yml` — matches `^/ready\b` (not `/ready-stack`) → trust gate → `clear_hold_command` - [ ] `flows/defaults/slash-unassign.yml` — matches `^/unassign` → trust gate → `apply_unassign_command` - [ ] `flows/defaults/slash-ready-stack.yml` — matches `^/ready-stack` → trust gate → `apply_ready_stack_command` ### Tests - [ ] Unit tests for each op + `is_trusted_user` predicate - [ ] Expression-eval tests for `comment_matches` - [ ] Flow integration tests for each slash flow (trusted user accepted; untrusted user rejected) - [ ] Verify `/breakdown` flow still works (no regression on the one already-ported command) ### Cleanup - [ ] Delete `handleSlashCommandOther` and `applyReadyStackCommand` handler exports from `event-handlers.ts` (keep `applyHoldCommand` / `applyUnassignCommand` / `applyReadyStackCommand` as op implementations) - [ ] Delete their tests ## Out of scope - CI events — separate ticket (#1092) - PR-closed cleanup — separate ticket (#1093) - `legacy*` executor hooks — separate ticket ## References - `apps/server/src/domain/workflow/event-handlers.ts:754-820` (handler impl + command regexes) - `apps/server/src/domain/workflow/deps.ts` (`applyHoldCommand`, `applyUnassignCommand`) - `flows/defaults/breakdown-comment.yml` (template for issue_comment trigger usage)

claude-desktop referenced this issue

2026-05-10 23:31:28 +00:00

Split event-handlers.ts into topical modules and delete the file #1096

claude-desktop added the

area:flows

type:user-story

labels

2026-05-10 23:31:54 +00:00

charles referenced this issue from a commit

2026-05-11 01:25:15 +00:00

feat(flows-yaml): port slash commands to YAML (/hold /ready /no-ready /unassign /ready-stack)

claude-desktop referenced this issue from a pull request that will close it,

2026-05-11 01:25:29 +00:00

feat(flows-yaml): port slash commands to YAML (/hold /ready /no-ready /unassign /ready-stack) #1099

claude-desktop closed this issue

2026-05-11 01:46:39 +00:00

claude-desktop referenced this issue

2026-05-11 03:04:12 +00:00

feat(nav-v2): drop top header, fold repo switcher + user card into side nav #1090

No Branch/Tag specified

main

chore/sync-pre-push-from-forge-base

fix/flows-yaml-dispatch-identity

feat/board-tap-to-assign

dev/1107

code-lead/1106

code-lead/1108

dev/1104

code-lead/1103

code-lead/1080

dev/1087

feat/flows-yaml-ci-events

chore/board-drop-stalled-and-density-controls

fix/flows-yaml-routes-always-register

flows-yaml/api-defaults

dev/1023

fix/event-log-history-bleed

fix/janitor-fix-ci-logs-and-cap

dev/1022

fix/board-card-provider

code-lead/1036

dev/1025

code-lead/1020

dev/1017

code-lead/1026

feat/web-shortcut-registry-1018

dev/1015

code-lead/1009

code-lead/1008

dev/975

dev/969

dev/973

dev/967

code-lead/968

code-lead/953

dev/970

dev/976

code-lead/966

code-lead/956

code-lead/951

dev/962

dev/963

dev/977

dev/955

dev/983

dev/961

dev/974

code-lead/950

code-lead/939

dev/941

dev/940

dev/937

dev/938

dev/936

dev/935

feat/web-i18n-fr-locale

feat/spec-editor-ui-polish

chore/drop-legacy-compat

fix/skills-drop-preview-pane

fix/882-skills-safety-rail

dev/911

dev/909

dev/923

dev/917

dev/915

feat/879-sr11-m2-drop-legacy-skill

code-lead/873

dev/881

code-lead/869

dev/867

code-lead/845

code-lead/843

code-lead/844

dev/837

dev/861

dev/849

code-lead/837

code-lead/842

fix/dedup-rebase-inflight

dev/838

code-lead/847

dev/833

code-lead/848

pr/838

code-lead/841

feat/settings-save-bar/836

code-lead/840

dev/846

code-lead/839

dev/832

fix/board-sse-stale-cache

dev/834

dev/835

feat/settings-breadcrumbs

feat/forge-oauth-credentials

refactor/service-config-consolidation

feat/agent-tokens-to-secrets

feat/gitlab-oauth-to-db

feat/authelia-rip-and-voice-fixes

fix/rebase-storm-and-dead-letter

code-lead/797

code-lead/796

dev/811

code-lead/798

dev/810

code-lead/795

dev/808

code-lead/794

dev/805

dev/802

dev/803

feat/avatar-menu-settings-entry

feat/per-agent-token-tracking

dev/793

dev/747

dev/752

code-lead/790

code-lead/759

dev/756

dev/760

dev/741

dev/767

dev/740

dev/709

dev/644

dev/637

boss/614

dev/600

dev/611

dev/585

fix/login-bonus-fixes

boss/544

dev/542

refactor/api-prefix-and-session-gate

dev/489

boss/531

boss/518

dev/499

boss/516

dev/530

dev/517

dev/519

dev/515

dev/522

dev/503

dev/471

boss/329

dev/417

dev/418

dev/402

boss/327

dev/334

dev/332

boss/326

boss/325

dev/331

boss/324

boss/323

boss/322

dev/294

test/s11-task-analytics

dev/262

boss/270

dev/268

foreman/ui-consolidation-spec

dev/234

boss/196

boss/176

boss/164

fix/124-session-persist-bind

boss/52

dev/87

boss/73

dev/77

dev/81

dev/82

boss/79

dev/42

dev/35

boss/7

No results found.

Labels

Clear labels

area:agents

Agent types, pool scheduling, per-instance config

area:dashboard

Dashboard UI and observability surfaces

area:database

DB layer — schema, migrations, ORM, raw SQL

area:design

UI/UX mockup work — routes to designer agent

area:design-review

Design review dispatch — routes to design-reviewer agent

area:flows

Flow runner — YAML loader, executor, op registry, expression eval

area:infra

Deployment, isolation, containers, systemd units

area:meta

Tracking, scaffolding, project setup

area:security

Security — routes to reviewer-security (opus)

area:sessions

Session-id store, Claude SDK resume logic

area:webhook

Forgejo webhook routing and handlers

area:workdir

Clone cache, worktrees, git identity

security

Security-sensitive issue

Tracking or decisions, not implementation work

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/claude-hooks#1094

Reference in a new issue

Repository

charles/claude-hooks

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns