chore: drop agentTypeRouting table and legacy label/review routing config

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

charles/agent-hooks#1229

claude-desktop commented

2026-05-16 21:09:03 +00:00

Collaborator

Remove agent_type_routing table, routing fields from agent_type_config, and all code that reads/writes them. Flow YAML is now the single routing source of truth.

Depends on: AgentRole removal issue (#1226 — routing code must be dead before dropping tables).

Acceptance criteria

DB migration

agent_type_routing table dropped
reviews_authors, reviews_labels, match_labels columns dropped from agent_type_config
Drizzle schema updated

Code removal

agentTypeRouting definition removed from schema/agent-type.ts
routes_labels_json, reviews_authors_json, reviews_labels_json, label_rules_json, assignee_rules_json removed from all read/write paths
webhook-config-parser.ts — routing block parsing removed
webhook-config-lookup.ts — labelToRoute, authorToReviewer, labelToReviewer maps and build logic removed
applyRoutingFromConfig() in webhook-routing.ts — label/review routing logic stripped; only flag-based pool building survives
RoutingInputType.routes_labels, reviews_authors, reviews_labels removed
BAKED_DEFAULT_INPUT routing entries removed
onboarding-apply.ts — no longer writes routing rows

Tests

Label-routing tests removed from webhook-routing.test.ts
Routing parse tests removed from webhook-config-parser.test.ts
No remaining references to routes_labels, reviews_authors, reviews_labels, labelToRoute, authorToReviewer

Out of scope

issue-labeled.yml flow content (label routing lives there now)

References

schema/agent-type.ts:97 — agentTypeRouting table
webhook-routing.ts:133 — BAKED_DEFAULT_INPUT
webhook-config-lookup.ts:610 — roleForType etc (removed in AgentRole issue)

Remove `agent_type_routing` table, routing fields from `agent_type_config`, and all code that reads/writes them. Flow YAML is now the single routing source of truth. Depends on: AgentRole removal issue (#1226 — routing code must be dead before dropping tables). ## Acceptance criteria ### DB migration - [ ] `agent_type_routing` table dropped - [ ] `reviews_authors`, `reviews_labels`, `match_labels` columns dropped from `agent_type_config` - [ ] Drizzle schema updated ### Code removal - [ ] `agentTypeRouting` definition removed from `schema/agent-type.ts` - [ ] `routes_labels_json`, `reviews_authors_json`, `reviews_labels_json`, `label_rules_json`, `assignee_rules_json` removed from all read/write paths - [ ] `webhook-config-parser.ts` — routing block parsing removed - [ ] `webhook-config-lookup.ts` — `labelToRoute`, `authorToReviewer`, `labelToReviewer` maps and build logic removed - [ ] `applyRoutingFromConfig()` in `webhook-routing.ts` — label/review routing logic stripped; only flag-based pool building survives - [ ] `RoutingInputType.routes_labels`, `reviews_authors`, `reviews_labels` removed - [ ] `BAKED_DEFAULT_INPUT` routing entries removed - [ ] `onboarding-apply.ts` — no longer writes routing rows ### Tests - [ ] Label-routing tests removed from `webhook-routing.test.ts` - [ ] Routing parse tests removed from `webhook-config-parser.test.ts` - [ ] No remaining references to `routes_labels`, `reviews_authors`, `reviews_labels`, `labelToRoute`, `authorToReviewer` ## Out of scope - `issue-labeled.yml` flow content (label routing lives there now) ## References - `schema/agent-type.ts:97` — agentTypeRouting table - `webhook-routing.ts:133` — BAKED_DEFAULT_INPUT - `webhook-config-lookup.ts:610` — roleForType etc (removed in AgentRole issue)

claude-desktop added the

labels

2026-05-16 21:09:13 +00:00

claude-desktop added this to the agent-role-removal milestone

2026-05-16 21:13:08 +00:00

claude-desktop closed this issue

2026-05-16 21:47:00 +00:00