refactor(shared): single TaskStatus enum replaces dual db-status / ui_status split

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#1167 feat(web): add global approval banner so blocked tasks are visible without scrolling

charles/agent-hooks

Reference

charles/agent-hooks#1163

claude-desktop commented

2026-05-14 22:05:19 +00:00

Collaborator

Acceptance criteria

Package

packages/shared/src/task-status.ts exports TaskStatus (canonical union covering all DB values) and DisplayStatus (UI display states)
toDisplayStatus(s: TaskStatus): DisplayStatus mapping function in the same file — replaces the dual-enum mapping currently scattered across components
packages/shared/src/index.ts re-exports both types + the mapping function

DB layer

Drizzle task_history.status column type aligned to TaskStatus string union
No raw string literals for status values in query files — use the enum values

Web

task.ui_status computed field removed from the API wire format
All components that read task.ui_status replaced with toDisplayStatus(task.status)
StatusPill props unchanged (still consumes DisplayStatus values)

Quality

just qa passes (typecheck + lint clean)
No new status values added (out of scope)

Out of scope

Adding new status values (separate ticket)
Changing StatusPill visual appearance
Changing task lifecycle logic

References

agent-output-unification audit 2026-05-15
Inconsistency: "Status Terminology Mismatch" (HIGH)

As a developer, I want a single exhaustive TaskStatus type shared between the DB layer and the UI, so that adding a new status state doesn't require updating two enums and two mapping functions in separate packages. ### Acceptance criteria #### Package - [ ] `packages/shared/src/task-status.ts` exports `TaskStatus` (canonical union covering all DB values) and `DisplayStatus` (UI display states) - [ ] `toDisplayStatus(s: TaskStatus): DisplayStatus` mapping function in the same file — replaces the dual-enum mapping currently scattered across components - [ ] `packages/shared/src/index.ts` re-exports both types + the mapping function #### DB layer - [ ] Drizzle `task_history.status` column type aligned to `TaskStatus` string union - [ ] No raw string literals for status values in query files — use the enum values #### Web - [ ] `task.ui_status` computed field removed from the API wire format - [ ] All components that read `task.ui_status` replaced with `toDisplayStatus(task.status)` - [ ] `StatusPill` props unchanged (still consumes `DisplayStatus` values) #### Quality - [ ] `just qa` passes (typecheck + lint clean) - [ ] No new status values added (out of scope) ### Out of scope - Adding new status values (separate ticket) - Changing `StatusPill` visual appearance - Changing task lifecycle logic ### References - agent-output-unification audit 2026-05-15 - Inconsistency: "Status Terminology Mismatch" (HIGH)

claude-desktop added this to the agent-output-unification milestone

claude-desktop added the

labels

dev was assigned by architect

2026-05-14 22:12:40 +00:00

dev referenced this issue from a commit

2026-05-14 22:27:15 +00:00

refactor(shared): single TaskStatus enum replaces dual db-status / ui_status split

dev referenced this issue from a pull request that will close it,

2026-05-14 22:27:40 +00:00

refactor(shared): single TaskStatus enum replaces dual db-status / ui_status split #1183

charles referenced this issue from a commit