fix: encapsulate mutable draining/drainScheduled flags in render-queue.ts #1140

New issue

Closed

opened 2026-05-13 21:28:08 +00:00 by claude-desktop · 0 comments

claude-desktop commented

2026-05-13 21:28:08 +00:00

Collaborator

As a developer maintaining the agent-env-sync pipeline, I want the mutable draining and drainScheduled flags in render-queue.ts to be encapsulated, so that the queue state is self-contained and the control flow is obvious to a reader unfamiliar with the module.

Current state

apps/server/src/infrastructure/agent-env-sync/render-queue.ts lines 75 and 82 expose two bare let flags at module scope
The drain loop at lines 88–121 reads/writes these flags with no guard primitive
JavaScript single-threading prevents races today, but the pattern is fragile if Bun workers are ever introduced

Fix

Wrap queue state (pending items + draining + drainScheduled) in a single closure or class exported as a singleton
All state mutations go through the closure/class methods — no bare module-level lets

Out of scope

Changing the queue's public API (enqueue, drain)
Parallelising renders (single-queue behaviour preserved)

References

apps/server/src/infrastructure/agent-env-sync/render-queue.ts:75,82
Codebase audit 2026-05-13

As a developer maintaining the agent-env-sync pipeline, I want the mutable `draining` and `drainScheduled` flags in `render-queue.ts` to be encapsulated, so that the queue state is self-contained and the control flow is obvious to a reader unfamiliar with the module. ### Current state - `apps/server/src/infrastructure/agent-env-sync/render-queue.ts` lines 75 and 82 expose two bare `let` flags at module scope - The drain loop at lines 88–121 reads/writes these flags with no guard primitive - JavaScript single-threading prevents races today, but the pattern is fragile if Bun workers are ever introduced ### Fix - [ ] Wrap queue state (pending items + `draining` + `drainScheduled`) in a single closure or class exported as a singleton - [ ] All state mutations go through the closure/class methods — no bare module-level `let`s ### Out of scope - Changing the queue's public API (`enqueue`, `drain`) - Parallelising renders (single-queue behaviour preserved) ### References - `apps/server/src/infrastructure/agent-env-sync/render-queue.ts:75,82` - Codebase audit 2026-05-13

claude-desktop added the

area:agents

type:chore

labels

2026-05-13 21:28:23 +00:00